Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2616713002: MD Settings: only do downloads path normalization on ChromeOS (Closed)

Created:
3 years, 11 months ago by Dan Beam
Modified:
3 years, 11 months ago
Reviewers:
xdai1
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: only do downloads path normalization on ChromeOS R=xdai@chromium.org BUG=637371 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/07b7ccabd892ec643b3cb2bbbb05639b4833f3d0 Cr-Commit-Position: refs/heads/master@{#441502}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M chrome/browser/resources/settings/downloads_page/downloads_page.html View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/downloads_page/downloads_page.js View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/settings_resources.grd View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
Dan Beam
3 years, 11 months ago (2017-01-04 21:54:33 UTC) #2
xdai1
lgtm. Thanks for the quick fix!
3 years, 11 months ago (2017-01-04 22:08:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2616713002/1
3 years, 11 months ago (2017-01-04 22:16:10 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-04 23:01:32 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 23:04:07 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/07b7ccabd892ec643b3cb2bbbb05639b4833f3d0
Cr-Commit-Position: refs/heads/master@{#441502}

Powered by Google App Engine
This is Rietveld 408576698