Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 2608643002: Mark kKnownRootCertSHA256Hashes as const (Closed)

Created:
3 years, 11 months ago by brucedawson
Modified:
3 years, 11 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark kKnownRootCertSHA256Hashes as const Marking kKnownRootCertSHA256Hashes as const puts it into the read-only data segment which has various minor advantages such as making data corruption impossible and guaranteeing that the data will always be in shareable pages. R=rsleevi@chromium.org BUG=677351 Committed: https://crrev.com/9d105a8645752563d7a24212f50b838f9ac313d2 Cr-Commit-Position: refs/heads/master@{#440914}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/cert/x509_certificate_known_roots_win.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (10 generated)
brucedawson
3 years, 11 months ago (2016-12-29 00:41:58 UTC) #7
Ryan Sleevi
Ouch! Good catch. LGTM.
3 years, 11 months ago (2016-12-29 00:43:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2608643002/1
3 years, 11 months ago (2016-12-29 00:44:00 UTC) #10
brucedawson
On 2016/12/29 00:41:58, brucedawson wrote: Hmmm. The try bots didn't actually compile the code. It ...
3 years, 11 months ago (2016-12-29 00:45:56 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2016-12-29 00:49:38 UTC) #14
Ryan Sleevi
On 2016/12/29 00:45:56, brucedawson wrote: > On 2016/12/29 00:41:58, brucedawson wrote: > > Hmmm. The ...
3 years, 11 months ago (2016-12-29 00:55:12 UTC) #15
brucedawson
> Looks like the trybots ignored it because it wasn't in net.gypi because it's > ...
3 years, 11 months ago (2016-12-29 01:08:48 UTC) #16
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:51:02 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9d105a8645752563d7a24212f50b838f9ac313d2
Cr-Commit-Position: refs/heads/master@{#440914}

Powered by Google App Engine
This is Rietveld 408576698