Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2608643002:
Mark kKnownRootCertSHA256Hashes as const (Closed)
|
Created:
3 years, 11 months ago by brucedawson Modified:
3 years, 11 months ago Reviewers:
Ryan Sleevi CC:
chromium-reviews, cbentzel+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMark kKnownRootCertSHA256Hashes as const
Marking kKnownRootCertSHA256Hashes as const puts it into the read-only
data segment which has various minor advantages such as making data
corruption impossible and guaranteeing that the data will always be
in shareable pages.
R=rsleevi@chromium.org
BUG=677351
Committed: https://crrev.com/9d105a8645752563d7a24212f50b838f9ac313d2
Cr-Commit-Position: refs/heads/master@{#440914}
Patch Set 1 #
Messages
Total messages: 18 (10 generated)
The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Mark kKnownRootCertSHA256Hashes as const Marking kKnownRootCertSHA256Hashes as const puts it into the read-only data segment which has various minor advantages, including avoiding data corruption and avoiding having the edge-pages dirtied and written to the page file. R=rsleevi@chromium.org ========== to ========== Mark kKnownRootCertSHA256Hashes as const Marking kKnownRootCertSHA256Hashes as const puts it into the read-only data segment which has various minor advantages, including avoiding data corruption and avoiding having the edge-pages dirtied and written to the page file. R=rsleevi@chromium.org BUG=677351 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Mark kKnownRootCertSHA256Hashes as const Marking kKnownRootCertSHA256Hashes as const puts it into the read-only data segment which has various minor advantages, including avoiding data corruption and avoiding having the edge-pages dirtied and written to the page file. R=rsleevi@chromium.org BUG=677351 ========== to ========== Mark kKnownRootCertSHA256Hashes as const Marking kKnownRootCertSHA256Hashes as const puts it into the read-only data segment which has various minor advantages such as making data corruption impossible and guaranteeing that the data will always be in shareable pages. R=rsleevi@chromium.org BUG=677351 ==========
Ouch! Good catch. LGTM.
The CQ bit was checked by rsleevi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/12/29 00:41:58, brucedawson wrote: Hmmm. The try bots didn't actually compile the code. It compiles and runs locally but I'd rather get the try bots chewing on it before landing the change.
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1482972228305620, "parent_rev":
"07fe56272803b1bb90b393008bdadc936793f365", "commit_rev":
"3622a6640d8709e49186ba7c3fb7ccd90e2aa510"}
Message was sent while issue was closed.
Description was changed from ========== Mark kKnownRootCertSHA256Hashes as const Marking kKnownRootCertSHA256Hashes as const puts it into the read-only data segment which has various minor advantages such as making data corruption impossible and guaranteeing that the data will always be in shareable pages. R=rsleevi@chromium.org BUG=677351 ========== to ========== Mark kKnownRootCertSHA256Hashes as const Marking kKnownRootCertSHA256Hashes as const puts it into the read-only data segment which has various minor advantages such as making data corruption impossible and guaranteeing that the data will always be in shareable pages. R=rsleevi@chromium.org BUG=677351 Review-Url: https://codereview.chromium.org/2608643002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
On 2016/12/29 00:45:56, brucedawson wrote: > On 2016/12/29 00:41:58, brucedawson wrote: > > Hmmm. The try bots didn't actually compile the code. It compiles and runs > locally but I'd rather get the try bots chewing on it before landing the change. Looks like the trybots ignored it because it wasn't in net.gypi because it's more of a .inc file for direct inclusion. However, because it was omitted from net.gypi, it wasn't included in net.isolate, so it didn't recompile.
Message was sent while issue was closed.
> Looks like the trybots ignored it because it wasn't in net.gypi because it's > more of a .inc file for direct inclusion. However, because it was omitted from > net.gypi, it wasn't included in net.isolate, so it didn't recompile. Gotcha. I didn't realize how that worked. I filed crbug.com/677355 to track this.
Message was sent while issue was closed.
Description was changed from ========== Mark kKnownRootCertSHA256Hashes as const Marking kKnownRootCertSHA256Hashes as const puts it into the read-only data segment which has various minor advantages such as making data corruption impossible and guaranteeing that the data will always be in shareable pages. R=rsleevi@chromium.org BUG=677351 Review-Url: https://codereview.chromium.org/2608643002 ========== to ========== Mark kKnownRootCertSHA256Hashes as const Marking kKnownRootCertSHA256Hashes as const puts it into the read-only data segment which has various minor advantages such as making data corruption impossible and guaranteeing that the data will always be in shareable pages. R=rsleevi@chromium.org BUG=677351 Committed: https://crrev.com/9d105a8645752563d7a24212f50b838f9ac313d2 Cr-Commit-Position: refs/heads/master@{#440914} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/9d105a8645752563d7a24212f50b838f9ac313d2 Cr-Commit-Position: refs/heads/master@{#440914} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
