Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1107)

Unified Diff: components/offline_pages/core/background/request_coordinator.cc

Issue 2608553002: [OfflinePages] Improve visiblity/handling of "Loading not started" case (Closed)
Patch Set: Addes ! low-end device default to test Setup Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/core/background/request_coordinator.cc
diff --git a/components/offline_pages/core/background/request_coordinator.cc b/components/offline_pages/core/background/request_coordinator.cc
index f098edfaf85f348f69e0cda5fd4c0201d09d77da..6860c39fc2ae563874c0bd8352936e40f0232e7a 100644
--- a/components/offline_pages/core/background/request_coordinator.cc
+++ b/components/offline_pages/core/background/request_coordinator.cc
@@ -806,8 +806,7 @@ void RequestCoordinator::StartOffliner(
update_result->item_statuses.at(0).first != request_id ||
update_result->item_statuses.at(0).second != ItemActionStatus::SUCCESS) {
is_busy_ = false;
- // TODO(fgorski): what is the best result? Do we create a new status?
- StopProcessing(Offliner::LOADING_NOT_STARTED);
+ StopProcessing(Offliner::QUEUE_UPDATE_FAILED);
DVLOG(1) << "Failed to mark attempt started: " << request_id;
UpdateRequestResult request_result =
update_result->store_state != StoreState::LOADED
@@ -846,7 +845,7 @@ void RequestCoordinator::StartOffliner(
} else {
is_busy_ = false;
DVLOG(0) << "Unable to start LoadAndSave";
- StopProcessing(Offliner::LOADING_NOT_STARTED);
+ StopProcessing(Offliner::LOADING_NOT_ACCEPTED);
// We need to undo the MarkAttemptStarted that brought us to this
// method since we didn't success in starting after all.

Powered by Google App Engine
This is Rietveld 408576698