Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Unified Diff: components/offline_pages/core/background/offliner.h

Issue 2608553002: [OfflinePages] Improve visiblity/handling of "Loading not started" case (Closed)
Patch Set: Addes ! low-end device default to test Setup Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/core/background/offliner.h
diff --git a/components/offline_pages/core/background/offliner.h b/components/offline_pages/core/background/offliner.h
index a0159de5bc3169fe9704ad02f1ef8d16984f1979..a7a5718596cc1c89d7d29e26c13aa21730241d24 100644
--- a/components/offline_pages/core/background/offliner.h
+++ b/components/offline_pages/core/background/offliner.h
@@ -40,13 +40,19 @@ class Offliner {
FOREGROUND_CANCELED = 7,
// RequestCoordinator canceled request attempt per time limit.
REQUEST_COORDINATOR_TIMED_OUT = 8,
- // The loader did not accept/start the request.
- LOADING_NOT_STARTED = 9,
+ // Deprecated. The RequestCoordinator did not start loading the request.
+ DEPRECATED_LOADING_NOT_STARTED = 9,
// Loader failed with hard error so should not retry the request.
LOADING_FAILED_NO_RETRY = 10,
// Loader failed with some error that suggests we should not continue
// processing another request at this time.
LOADING_FAILED_NO_NEXT = 11,
+ // The RequestCoordinator tried to start loading the request but the
+ // loading request was not accepted.
+ LOADING_NOT_ACCEPTED = 12,
+ // The RequestCoordinator did not start loading the request because
+ // updating the status in the request queue failed.
+ QUEUE_UPDATE_FAILED = 13,
// NOTE: insert new values above this line and update histogram enum too.
STATUS_COUNT
};

Powered by Google App Engine
This is Rietveld 408576698