Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Unified Diff: components/offline_pages/core/background/request_coordinator_event_logger.cc

Issue 2608553002: [OfflinePages] Improve visiblity/handling of "Loading not started" case (Closed)
Patch Set: Addes ! low-end device default to test Setup Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/core/background/request_coordinator_event_logger.cc
diff --git a/components/offline_pages/core/background/request_coordinator_event_logger.cc b/components/offline_pages/core/background/request_coordinator_event_logger.cc
index 834f090f661b6ad8918f6d94bebbe18d2c1b53ed..a4d8edf2e7280123166ac64997592356567b33aa 100644
--- a/components/offline_pages/core/background/request_coordinator_event_logger.cc
+++ b/components/offline_pages/core/background/request_coordinator_event_logger.cc
@@ -29,12 +29,16 @@ static std::string OfflinerRequestStatusToString(
return "FOREGROUND_CANCELED";
case Offliner::REQUEST_COORDINATOR_TIMED_OUT:
return "REQUEST_COORDINATOR_TIMED_OUT";
- case Offliner::LOADING_NOT_STARTED:
- return "LOADING_NOT_STARTED";
+ case Offliner::DEPRECATED_LOADING_NOT_STARTED:
+ return "DEPRECATED_LOADING_NOT_STARTED";
case Offliner::LOADING_FAILED_NO_RETRY:
return "LOADING_FAILED_NO_RETRY";
case Offliner::LOADING_FAILED_NO_NEXT:
return "LOADING_FAILED_NO_NEXT";
+ case Offliner::LOADING_NOT_ACCEPTED:
+ return "LOADING_NOT_ACCEPTED";
+ case Offliner::QUEUE_UPDATE_FAILED:
+ return "QUEUE_UPDATE_FAILED";
default:
NOTREACHED();
return std::to_string(static_cast<int>(request_status));

Powered by Google App Engine
This is Rietveld 408576698