chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc - Issue 2608553002: [OfflinePages] Improve visiblity/handling of "Loading not started" case

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc

Issue 2608553002: [OfflinePages] Improve visiblity/handling of "Loading not started" case (Closed)

Patch Set: Addes ! low-end device default to test Setup Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/offline_pages/prerendering_offliner.cc ('k') | components/offline_pages/core/background/offliner.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc

diff --git a/chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc b/chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc

index 261a6544ab8e385a38f2827bc26067b3971173f7..b9a3f70ce48c1cfcdd025149306d2d4bb4e012d2 100644

--- a/chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc

+++ b/chrome/browser/android/offline_pages/prerendering_offliner_unittest.cc

@@ -43,7 +43,7 @@ class MockPrerenderingLoader : public PrerenderingLoader {

~MockPrerenderingLoader() override {}

bool LoadPage(const GURL& url, const LoadPageCallback& callback) override {

- mock_loading_ = true;

+ mock_loading_ = can_prerender_;

load_page_callback_ = callback;

return mock_loading_;

}

@@ -53,7 +53,6 @@ class MockPrerenderingLoader : public PrerenderingLoader {

mock_loaded_ = false;

}

- bool CanPrerender() override { return can_prerender_; }

bool IsIdle() override { return !mock_loading_ && !mock_loaded_; }

bool IsLoaded() override { return mock_loaded_; }