Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2608503002: Remove mojo::WTFMap. (Closed)

Created:
3 years, 12 months ago by Sam McNally
Modified:
3 years, 11 months ago
Reviewers:
yzshen1
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove mojo::WTFMap. BUG=674766 Committed: https://crrev.com/2c8a4081d1e23d00905b2c33d262e1e0914ff9dd Cr-Commit-Position: refs/heads/master@{#440900}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -442 lines) Patch
M mojo/public/cpp/bindings/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/lib/wtf_serialization.h View 1 chunk +0 lines, -1 line 0 comments Download
D mojo/public/cpp/bindings/map_traits_wtf.h View 1 chunk +0 lines, -62 lines 0 comments Download
M mojo/public/cpp/bindings/struct_traits.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/cpp/bindings/tests/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D mojo/public/cpp/bindings/tests/wtf_map_unittest.cc View 1 chunk +0 lines, -113 lines 0 comments Download
M mojo/public/cpp/bindings/tests/wtf_types_unittest.cc View 1 chunk +0 lines, -60 lines 0 comments Download
D mojo/public/cpp/bindings/wtf_map.h View 1 chunk +0 lines, -200 lines 0 comments Download
M mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl View 1 chunk +0 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (12 generated)
Sam McNally
3 years, 12 months ago (2016-12-28 04:34:57 UTC) #9
yzshen1
lgtm
3 years, 11 months ago (2016-12-28 19:14:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2608503002/20001
3 years, 11 months ago (2016-12-28 22:09:50 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:20001)
3 years, 11 months ago (2016-12-28 22:14:31 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:50:32 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2c8a4081d1e23d00905b2c33d262e1e0914ff9dd
Cr-Commit-Position: refs/heads/master@{#440900}

Powered by Google App Engine
This is Rietveld 408576698