Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 2608443003: Redirect to play store app for web play store URL fallback. (Closed)

Created:
3 years, 12 months ago by Maria
Modified:
3 years, 11 months ago
Reviewers:
Ted C
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Redirect to play store app for web play store URL fallback. A fix for the initial implementation in https://codereview.chromium.org/2595773002/ where we would only redirect to play store in one of the cases where fallback URL is used. Move the code to the general path for clobber instead. BUG=638672 Committed: https://crrev.com/06ec5b901da88d125dc7a441651d9926195070aa Cr-Commit-Position: refs/heads/master@{#441199}

Patch Set 1 #

Patch Set 2 : Check package isn't null #

Patch Set 3 : Rebase #

Patch Set 4 : Fallback to package name as market referrer. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -41 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java View 1 2 3 3 chunks +50 lines, -41 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java View 1 2 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
Maria
3 years, 12 months ago (2016-12-27 20:31:34 UTC) #2
Ted C
lgtm
3 years, 12 months ago (2016-12-27 20:59:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2608443003/20001
3 years, 12 months ago (2016-12-27 21:45:30 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/128266) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 12 months ago (2016-12-27 21:47:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2608443003/40001
3 years, 11 months ago (2016-12-29 00:29:02 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/205397)
3 years, 11 months ago (2016-12-29 01:54:52 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2608443003/60001
3 years, 11 months ago (2017-01-03 19:31:23 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
3 years, 11 months ago (2017-01-03 20:10:33 UTC) #18
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 20:13:26 UTC) #20
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/06ec5b901da88d125dc7a441651d9926195070aa
Cr-Commit-Position: refs/heads/master@{#441199}

Powered by Google App Engine
This is Rietveld 408576698