Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java

Issue 2608443003: Redirect to play store app for web play store URL fallback. (Closed)
Patch Set: Fallback to package name as market referrer. Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
index 62926c3592ca9139f52fe0b9b29a1c0193d3747c..2cd72e96b9ff12a41b7001ef47276a3d9c352434 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java
@@ -713,6 +713,34 @@ public class ExternalNavigationHandlerTest extends NativeLibraryTestBase {
}
@SmallTest
+ public void testFallbackUrl_RedirectToIntentToMarket() {
+ TestContext context = new TestContext();
+ TabRedirectHandler redirectHandler = new TabRedirectHandler(context);
+
+ redirectHandler.updateNewUrlLoading(PageTransition.TYPED, false, false, 0, 0);
+ checkUrl("http://goo.gl/abcdefg")
+ .withPageTransition(PageTransition.TYPED)
+ .withRedirectHandler(redirectHandler)
+ .expecting(OverrideUrlLoadingResult.NO_OVERRIDE, IGNORE);
+
+ redirectHandler.updateNewUrlLoading(PageTransition.LINK, false, false, 0, 0);
+ String realIntent = "intent:///name/nm0000158#Intent;scheme=imdb;package=com.imdb.mobile;"
+ + "S." + ExternalNavigationHandler.EXTRA_BROWSER_FALLBACK_URL + "="
+ + "https://play.google.com/store/apps/details?id=com.imdb.mobile"
+ + "&referrer=mypage;end";
+
+ checkUrl(realIntent)
+ .withPageTransition(PageTransition.LINK)
+ .withIsRedirect(true)
+ .withRedirectHandler(redirectHandler)
+ .expecting(OverrideUrlLoadingResult.OVERRIDE_WITH_EXTERNAL_INTENT,
+ START_OTHER_ACTIVITY);
+
+ assertEquals("market://details?id=com.imdb.mobile&referrer=mypage",
+ mDelegate.startActivityIntent.getDataString());
+ }
+
+ @SmallTest
public void testFallbackUrl_IntentResolutionFailsWithoutPackageName() {
// IMDB app isn't installed.
mDelegate.setCanResolveActivity(false);
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698