cros: Small visual tweaks for material design palette.

ash/common/system/chromeos/palette/palette_tray.cc

Index: ash/common/system/chromeos/palette/palette_tray.cc
diff --git a/ash/common/system/chromeos/palette/palette_tray.cc b/ash/common/system/chromeos/palette/palette_tray.cc
index 179be69fd967c0b5e0bbcde240bccb65415f2f16..ff39bc12be3fd5116f3c54fc62133010c0a11866 100644
--- a/ash/common/system/chromeos/palette/palette_tray.cc
+++ b/ash/common/system/chromeos/palette/palette_tray.cc
@@ -45,34 +45,25 @@ namespace {
 
 // Predefined padding for the icon used in this tray. These are to be set to the
 // border of the icon, depending on the current |shelf_alignment()|.
-const int kHorizontalShelfHorizontalPadding = 8;
-const int kHorizontalShelfVerticalPadding = 4;
-const int kVerticalShelfHorizontalPadding = 2;
-const int kVerticalShelfVerticalPadding = 5;
+constexpr int kHorizontalShelfHorizontalPadding = 8;
+constexpr int kHorizontalShelfVerticalPadding = 4;
+constexpr int kVerticalShelfHorizontalPadding = 2;
+constexpr int kVerticalShelfVerticalPadding = 5;
 
 // Width of the palette itself (dp).
-const int kPaletteWidth = 332;
+constexpr int kPaletteWidth = 332;
 
 // Padding at the top/bottom of the palette (dp).
-const int kPalettePaddingOnTop = 4;
-const int kPalettePaddingOnBottom = 4;
-
-// Size of icon in the shelf (dp).
-const int kShelfIconSize = 18;
-
-// Vertical margin around the title view elements so that the title view height
-// matches kMenuButtonSize.
-const int kVerticalMarginAroundTitleView = 1;
+constexpr int kPalettePaddingOnTop = 4;
+constexpr int kPalettePaddingOnBottom = 2;
 
 // Margins between the title view and the edges around it (dp).
-const int kPaddingBetweenTitleAndLeftEdge = 12;
-const int kPaddingBetweenTitleAndSeparator = 3;
-
-// The distance between the title, help, and settings button in the title (dp).
-const int kHorizontalPaddingBetweenTitleEntries = 2;
+constexpr int kPaddingBetweenTitleAndLeftEdge = 12;
+constexpr int kPaddingBetweenTitleAndSeparator = 3;
 
 // Color of the separator.
-const SkColor kPaletteSeparatorColor = SkColorSetARGB(0x1E, 0x00, 0x00, 0x00);
+constexpr SkColor kPaletteSeparatorColor =
+    SkColorSetARGB(0x1E, 0x00, 0x00, 0x00);

[dcheng, 2017/01/06 03:06:18]

This breaks if NDEBUG isn't true, since this uses an inline function in debug
mode, and the function isn't marked constexpr:

../../ash/common/system/chromeos/palette/palette_tray.cc:65:19: error: constexpr
variable 'kPaletteSeparatorColor' must be initialized by a constant expression
constexpr SkColor kPaletteSeparatorColor =
                  ^
../../ash/common/system/chromeos/palette/palette_tray.cc:66:5: note:
non-constexpr function 'SkColorSetARGBInline' cannot be used in a constant
expression
    SkColorSetARGB(0x1E, 0x00, 0x00, 0x00);
    ^
../../third_party/skia/include/core/SkColor.h:53:36: note: expanded from macro
'SkColorSetARGB'
#define SkColorSetARGB(a, r, g, b) SkColorSetARGBInline(a, r, g, b)
                                   ^
../../third_party/skia/include/core/SkColor.h:32:23: note: declared here
static inline SkColor SkColorSetARGBInline(U8CPU a, U8CPU r, U8CPU g, U8CPU b)

 
 // Returns true if we are in a user session that can show the stylus tools.
 bool IsInUserSession() {
@@ -90,9 +81,8 @@ class TitleView : public views::View, public views::ButtonListener {
   explicit TitleView(PaletteTray* palette_tray) : palette_tray_(palette_tray) {
     // TODO(tdanderson|jdufault): Use TriView to handle the layout of the title.
     // See crbug.com/614453.
-    auto* box_layout = new views::BoxLayout(
-        views::BoxLayout::kHorizontal, 0, kVerticalMarginAroundTitleView,
-        kHorizontalPaddingBetweenTitleEntries);
+    auto* box_layout =
+        new views::BoxLayout(views::BoxLayout::kHorizontal, 0, 0, 0);
     SetLayoutManager(box_layout);
 
     title_label_ =
@@ -431,7 +421,7 @@ void PaletteTray::UpdateTrayIcon() {
   icon_->SetImage(CreateVectorIcon(
       palette_tool_manager_->GetActiveTrayIcon(
           palette_tool_manager_->GetActiveTool(ash::PaletteGroup::MODE)),
-      kShelfIconSize, kShelfIconColor));
+      kTrayIconSize, kShelfIconColor));
 }
 
 void PaletteTray::OnStylusStateChanged(ui::StylusState stylus_state) {