Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2608323002: Teach resource_sizes.py about webview_licenses.notice file (Closed)

Created:
3 years, 11 months ago by agrieve
Modified:
3 years, 11 months ago
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Teach resource_sizes.py about webview_licenses.notice file This was showing up under "unknown". This also makes resource_sizes.py print out a list of all unknown files. BUG=678004 Committed: https://crrev.com/0c10a5399c2ec24fdd2c6cf1d6656d58daa2f491 Cr-Commit-Position: refs/heads/master@{#441185}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M build/android/resource_sizes.py View 5 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
agrieve
On 2017/01/03 18:12:36, agrieve wrote: > Description was changed from > > ========== > Teach ...
3 years, 11 months ago (2017-01-03 18:12:54 UTC) #4
rnephew (Reviews Here)
On 2017/01/03 18:12:54, agrieve wrote: > On 2017/01/03 18:12:36, agrieve wrote: > > Description was ...
3 years, 11 months ago (2017-01-03 18:16:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2608323002/1
3 years, 11 months ago (2017-01-03 18:39:55 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-03 19:41:35 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-03 19:45:54 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0c10a5399c2ec24fdd2c6cf1d6656d58daa2f491
Cr-Commit-Position: refs/heads/master@{#441185}

Powered by Google App Engine
This is Rietveld 408576698