Teach resource_sizes.py about webview_licenses.notice file

build/android/resource_sizes.py

 #!/usr/bin/python
 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Prints the size of each given file and optionally computes the size of
    libchrome.so without the dependencies added for building with android NDK.
    Also breaks down the contents of the APK to determine the installed size
    and assign size contributions to different classes of file.
 """
@@ skipping 162 matching lines @@
 
   def __init__(self, name):
     self.name = name
     self._zip_infos = []
     self._extracted = []
 
   def AddZipInfo(self, zip_info, extracted=False):
     self._zip_infos.append(zip_info)
     self._extracted.append(extracted)
 
+  def AllEntries(self):
+    return iter(self._zip_infos)
+
   def GetNumEntries(self):
     return len(self._zip_infos)
 
   def FindByPattern(self, pattern):
     return next((i for i in self._zip_infos if re.match(pattern, i.filename)),
                 None)
 
   def FindLargest(self):
     return max(self._zip_infos, key=lambda i: i.file_size)
 
@@ skipping 27 matching lines @@
   java_code = make_group('Java code')
   native_resources_no_translations = make_group('Native resources (no l10n)')
   translations = make_group('Native resources (l10n)')
   icu_data = make_group('ICU (i18n library) data')
   v8_snapshots = make_group('V8 Snapshots')
   png_drawables = make_group('PNG drawables')
   res_directory = make_group('Non-compiled Android resources')
   arsc = make_group('Compiled Android resources')
   metadata = make_group('Package metadata')
   unknown = make_group('Unknown files')
+  notices = make_group('licenses.notice file')
 
   apk = zipfile.ZipFile(apk_filename, 'r')
   try:
     apk_contents = apk.infolist()
   finally:
     apk.close()
 
   total_apk_size = os.path.getsize(apk_filename)
   apk_basename = os.path.basename(apk_filename)
 
@@ skipping 15 matching lines @@
     elif filename.endswith('.bin'):
       v8_snapshots.AddZipInfo(member)
     elif filename.endswith('.png') or filename.endswith('.webp'):
       png_drawables.AddZipInfo(member)
     elif filename.startswith('res/'):
       res_directory.AddZipInfo(member)
     elif filename.endswith('.arsc'):
       arsc.AddZipInfo(member)
     elif filename.startswith('META-INF') or filename == 'AndroidManifest.xml':
       metadata.AddZipInfo(member)
+    elif filename.endswith('.notice'):
+      notices.AddZipInfo(member)
     else:
       unknown.AddZipInfo(member)
 
   total_install_size = total_apk_size
 
   for group in file_groups:
     install_size = group.ComputeInstallSize()
     total_install_size += group.ComputeExtractedSize()
 
     ReportPerfResult(chartjson, apk_basename + '_Breakdown',
@@ skipping 36 matching lines @@
   normalized_apk_size = total_apk_size
   # Always look at uncompressed .dex & .so.
   normalized_apk_size -= java_code.ComputeZippedSize()
   normalized_apk_size += java_code.ComputeUncompressedSize()
   normalized_apk_size -= native_code.ComputeZippedSize()
   normalized_apk_size += native_code.ComputeUncompressedSize()
   # Avoid noise caused when strings change and translations haven't yet been
   # updated.
   english_pak = translations.FindByPattern(r'.*/en[-_][Uu][Ss]\.l?pak')
   if english_pak:
+    # TODO(agrieve): This should also analyze .arsc file to remove non-en
+    # configs. http://crbug.com/677966
     normalized_apk_size -= translations.ComputeZippedSize()
     # 1.17 found by looking at Chrome.apk and seeing how much smaller en-US.pak
     # is relative to the average locale .pak.
     normalized_apk_size += int(
         english_pak.compress_size * translations.GetNumEntries() * 1.17)
 
   ReportPerfResult(chartjson, apk_basename + '_Specifics',
                    'normalized apk size', normalized_apk_size, 'bytes')
 
   ReportPerfResult(chartjson, apk_basename + '_Specifics',
                    'file count', len(apk_contents), 'zip entries')
 
+  for info in unknown.AllEntries():
+    print 'Unknown entry:', info.filename, info.compress_size
+
 
 def IsPakFileName(file_name):
   """Returns whether the given file name ends with .pak or .lpak."""
   return file_name.endswith('.pak') or file_name.endswith('.lpak')
 
 
 def PrintPakAnalysis(apk_filename, min_pak_resource_size):
   """Print sizes of all resources in all pak files in |apk_filename|."""
   print
   print 'Analyzing pak files in %s...' % apk_filename
@@ skipping 250 matching lines @@
 
   if chartjson:
     results_path = os.path.join(options.output_dir, 'results-chart.json')
     logging.critical('Dumping json to %s', results_path)
     with open(results_path, 'w') as json_file:
       json.dump(chartjson, json_file)
 
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv))