Remove ScriptController::updateDocument

third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp

Index: third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp b/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp
index c844933df3de3000ff9a7ca41652da2932386d81..a91fec16ef943389e2f17f4ab59cda592c873374 100644
--- a/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp
@@ -460,6 +460,10 @@ void WindowProxy::setSecurityToken(SecurityOrigin* origin) {
 
 void WindowProxy::updateDocument() {
   DCHECK(m_world->isMainWorld());
+  // TODO(haraken): Replace this with a better check once we introduce
+  // a lifecycle model for WindowProxy. This is checking if the context
+  // is not yet detached.
+  DCHECK(!m_scriptState || isContextInitialized());

[Yuki, 2017/01/05 13:21:26]

I think it's worth commenting that we can defer updating the document until when
the window proxy gets initialized because the WindowProxy initialization
includes updateDocument().  So we can return immediately if !m_scriptState (i.e.
!isGlobalInitialized()).

[haraken, 2017/01/05 23:46:19]

Done.

   if (!isContextInitialized())
     return;