Remove ScriptController::updateDocument

third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp

Index: third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp
index cae05d3022e14a0b931354a59bba65c9aee99c69..f41f398d35c566893659c585847705db20a497be 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp
@@ -209,12 +209,6 @@ void ScriptController::executeScriptInMainWorld(
                        InspectorUpdateCountersEvent::data());
 }
 
-bool ScriptController::initializeMainWorld() {
-  if (m_windowProxyManager->mainWorldProxy()->isContextInitialized())
-    return false;
-  return windowProxy(DOMWrapperWorld::mainWorld())->isContextInitialized();
-}
-
 WindowProxy* ScriptController::windowProxy(DOMWrapperWorld& world) {
   WindowProxy* windowProxy = m_windowProxyManager->windowProxy(world);
   if (!windowProxy->isContextInitialized()) {
@@ -303,13 +297,7 @@ void ScriptController::clearWindowProxy() {
 }
 
 void ScriptController::updateDocument() {
-  // For an uninitialized main window windowProxy, do not incur the cost of
-  // context initialization.

[Yuki, 2017/01/05 13:21:26]

I think this comment was very good.

[haraken, 2017/01/05 23:46:19]

Done.

-  if (!m_windowProxyManager->mainWorldProxy()->isGlobalInitialized())

[dcheng, 2017/01/05 16:20:32]

Note this is the only caller to isGlobalInitialized(). However, the last time I
tried to remove this, kouhei@ (who added this in
https://chromium.googlesource.com/chromium/src/+/246e25c5bd72fac9dce3b9b1254e...)
mentioned that this was a useful improvement for pages that never needed to use
JS: https://codereview.chromium.org/2392843002/#msg15

-    return;
-
-  if (!initializeMainWorld())
-    windowProxy(DOMWrapperWorld::mainWorld())->updateDocument();
+  m_windowProxyManager->mainWorldProxy()->updateDocument();
 }
 
 void ScriptController::namedItemAdded(HTMLDocument* doc,