Remove ScriptController::updateDocument

third_party/WebKit/Source/bindings/core/v8/WindowProxy.cpp

 /*
  * Copyright (C) 2008, 2009, 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 442 matching lines @@
     token = frameSecurityToken + token;
   }
 
   // NOTE: V8 does identity comparison in fast path, must use a symbol
   // as the security token.
   context->SetSecurityToken(v8AtomicString(m_isolate, token));
 }
 
 void WindowProxy::updateDocument() {
   DCHECK(m_world->isMainWorld());
+  // TODO(haraken): Replace this with a better check once we introduce
+  // a lifecycle model for WindowProxy. This is checking if the context
+  // is not yet detached.
+  DCHECK(!m_scriptState || isContextInitialized());

[Yuki, 2017/01/05 13:21:26]

I think it's worth commenting that we can defer updating the document until when
the window proxy gets initialized because the WindowProxy initialization
includes updateDocument().  So we can return immediately if !m_scriptState (i.e.
!isGlobalInitialized()).

[haraken, 2017/01/05 23:46:19]

Done.

   if (!isContextInitialized())
     return;
 
   updateActivityLogger();
   updateDocumentProperty();
   updateSecurityOrigin(m_frame->securityContext()->getSecurityOrigin());
 }
 
 static v8::Local<v8::Value> getNamedProperty(
     HTMLDocument* htmlDocument,
@@ skipping 77 matching lines @@
       .ToChecked();
 }
 
 void WindowProxy::updateSecurityOrigin(SecurityOrigin* origin) {
   if (!isContextInitialized())
     return;
   setSecurityToken(origin);
 }
 
 }  // namespace blink