Remove ScriptController::updateDocument

third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp

 /*
  * Copyright (C) 2008, 2009 Google Inc. All rights reserved.
  * Copyright (C) 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2014 Opera Software ASA. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
@@ skipping 191 matching lines @@
           V8ScriptRunner::runCompiledScript(
               isolate(), compiledScript.script(isolate()), frame()->document()),
           result, tryCatch))
     return;
 
   TRACE_EVENT_INSTANT1(TRACE_DISABLED_BY_DEFAULT("devtools.timeline"),
                        "UpdateCounters", TRACE_EVENT_SCOPE_THREAD, "data",
                        InspectorUpdateCountersEvent::data());
 }
 
-bool ScriptController::initializeMainWorld() {
-  if (m_windowProxyManager->mainWorldProxy()->isContextInitialized())
-    return false;
-  return windowProxy(DOMWrapperWorld::mainWorld())->isContextInitialized();
-}
-
 WindowProxy* ScriptController::windowProxy(DOMWrapperWorld& world) {
   WindowProxy* windowProxy = m_windowProxyManager->windowProxy(world);
   if (!windowProxy->isContextInitialized()) {
     windowProxy->initializeIfNeeded();
     if (world.isMainWorld())
       frame()->loader().dispatchDidClearWindowObjectInMainWorld();
   }
   return windowProxy;
 }
 
@@ skipping 68 matching lines @@
 }
 
 void ScriptController::clearWindowProxy() {
   // V8 binding expects ScriptController::clearWindowProxy only be called when a
   // frame is loading a new page. This creates a new context for the new page.
   m_windowProxyManager->clearForNavigation();
   MainThreadDebugger::instance()->didClearContextsForFrame(frame());
 }
 
 void ScriptController::updateDocument() {
-  // For an uninitialized main window windowProxy, do not incur the cost of
-  // context initialization.

[Yuki, 2017/01/05 13:21:26]

I think this comment was very good.

[haraken, 2017/01/05 23:46:19]

Done.

-  if (!m_windowProxyManager->mainWorldProxy()->isGlobalInitialized())

[dcheng, 2017/01/05 16:20:32]

Note this is the only caller to isGlobalInitialized(). However, the last time I
tried to remove this, kouhei@ (who added this in
https://chromium.googlesource.com/chromium/src/+/246e25c5bd72fac9dce3b9b1254e...)
mentioned that this was a useful improvement for pages that never needed to use
JS: https://codereview.chromium.org/2392843002/#msg15

-    return;
-
-  if (!initializeMainWorld())
-    windowProxy(DOMWrapperWorld::mainWorld())->updateDocument();
+  m_windowProxyManager->mainWorldProxy()->updateDocument();
 }
 
 void ScriptController::namedItemAdded(HTMLDocument* doc,
                                       const AtomicString& name) {
   windowProxy(DOMWrapperWorld::mainWorld())->namedItemAdded(doc, name);
 }
 
 void ScriptController::namedItemRemoved(HTMLDocument* doc,
                                         const AtomicString& name) {
   windowProxy(DOMWrapperWorld::mainWorld())->namedItemRemoved(doc, name);
@@ skipping 166 matching lines @@
     for (size_t i = 0; i < resultArray->Length(); ++i) {
       v8::Local<v8::Value> value;
       if (!resultArray->Get(scriptState->context(), i).ToLocal(&value))
         return;
       results->push_back(value);
     }
   }
 }
 
 }  // namespace blink