Abort running compiler dispatcher tasks under memory pressure

Abort running compiler dispatcher tasks under memory pressure

BUG=v8:5215
R=marja@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2608163006
Cr-Commit-Position: refs/heads/master@{#42084}
Committed: https://chromium.googlesource.com/v8/v8/+/10453e85d452432ab2fb3d812086e2486ffffe1f

[jochen (gone - plz use gerrit), 2017-01-04 15:27:11]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 15:27:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 15:33:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 15:33:55]

Dry run: Try jobs failed on following builders:
  v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/3...)

[jochen (gone - plz use gerrit), 2017-01-04 15:36:59]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 15:37:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 15:43:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 15:43:55]

Dry run: Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[jochen (gone - plz use gerrit), 2017-01-04 15:47:45]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 15:47:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 16:15:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 16:15:13]

Dry run: This issue passed the CQ dry run.

[vogelheim, 2017-01-04 16:52:20]

lgtm

Nice; this should be very useful!

https://codereview.chromium.org/2608163006/diff/40001/src/compiler-dispatcher...
File src/compiler-dispatcher/compiler-dispatcher.cc (right):

https://codereview.chromium.org/2608163006/diff/40001/src/compiler-dispatcher...
src/compiler-dispatcher/compiler-dispatcher.cc:360: level ==
MemoryPressureLevel::kModerate)) {
I find this a little weird. I think you're implementing a test for (level >
previous). I thought you could just compare enums, including enum classes. But
more importantly: Shouldn't we always drain the queue when a memory pressure
notification arrives?

I'd have expected something like: set abort_ == true for level != kNone and
drain the queue, regardless of previous level. And if abort_ is already true, we
don't have to do anything.

[jochen (gone - plz use gerrit), 2017-01-04 19:43:53]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[jochen (gone - plz use gerrit), 2017-01-04 19:44:02]

like this?

[commit-bot: I haz the power, 2017-01-04 19:44:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 20:13:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 20:13:01]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2017-01-05 09:20:54]

The CQ bit was checked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2017-01-05 09:20:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
vogelheim@chromium.org
Link to the patchset: https://codereview.chromium.org/2608163006/#ps60001
(title: "updates")

[commit-bot: I haz the power, 2017-01-05 09:20:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 09:22:34]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1483608054511480,
"parent_rev": "b371b0b7e7c7ab83aeea1306581ddebfa37a3b00", "commit_rev":
"10453e85d452432ab2fb3d812086e2486ffffe1f"}

[commit-bot: I haz the power, 2017-01-05 09:22:41]

Description was changed from

==========
Abort running compiler dispatcher tasks under memory pressure

BUG=v8:5215
R=marja@chromium.org,vogelheim@chromium.org
==========

to

==========
Abort running compiler dispatcher tasks under memory pressure

BUG=v8:5215
R=marja@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2608163006
Cr-Commit-Position: refs/heads/master@{#42084}
Committed:
https://chromium.googlesource.com/v8/v8/+/10453e85d452432ab2fb3d812086e2486ff...
==========

[commit-bot: I haz the power, 2017-01-05 09:22:41]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/10453e85d452432ab2fb3d812086e2486ff...