Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1483)

Issue 2618503002: Add a flag for printf debugging the compiler dispatcher (Closed)

Created:
3 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
3 years, 11 months ago
Reviewers:
vogelheim, marja
CC:
Michael Hablich, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add a flag for printf debugging the compiler dispatcher BUG=v8:5215 R=vogelheim@chromium.org,marja@chromium.org Review-Url: https://codereview.chromium.org/2618503002 Cr-Commit-Position: refs/heads/master@{#42091} Committed: https://chromium.googlesource.com/v8/v8/+/a5440323a26c65a6d57dcb2c853e1b449bf1a78c

Patch Set 1 #

Patch Set 2 : updates #

Total comments: 1

Patch Set 3 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -2 lines) Patch
M src/compiler-dispatcher/compiler-dispatcher.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler-dispatcher/compiler-dispatcher.cc View 1 2 11 chunks +59 lines, -1 line 0 comments Download
M src/compiler-dispatcher/compiler-dispatcher-job.h View 2 chunks +6 lines, -0 lines 0 comments Download
M src/compiler-dispatcher/compiler-dispatcher-job.cc View 1 11 chunks +40 lines, -1 line 0 comments Download
M src/compiler-dispatcher/compiler-dispatcher-tracer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler-dispatcher/compiler-dispatcher-tracer.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
jochen (gone - plz use gerrit)
ptal
3 years, 11 months ago (2017-01-05 07:17:42 UTC) #6
vogelheim
lgtm https://codereview.chromium.org/2618503002/diff/20001/src/compiler-dispatcher/compiler-dispatcher.cc File src/compiler-dispatcher/compiler-dispatcher.cc (right): https://codereview.chromium.org/2618503002/diff/20001/src/compiler-dispatcher/compiler-dispatcher.cc#newcode295 src/compiler-dispatcher/compiler-dispatcher.cc:295: PrintF("CompilerDispatcher: hurrying "); Hmm. I like the image ...
3 years, 11 months ago (2017-01-05 09:31:12 UTC) #10
marja
lgtm
3 years, 11 months ago (2017-01-05 09:33:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2618503002/40001
3 years, 11 months ago (2017-01-05 12:00:25 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 12:28:30 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/a5440323a26c65a6d57dcb2c853e1b449bf...

Powered by Google App Engine
This is Rietveld 408576698