Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4929)

Unified Diff: chrome/browser/ui/webui/devtools_ui.h

Issue 2607833002: DevTools: move front-end URL handling to DevToolsUIBindingds (Closed)
Patch Set: review comments addressed Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/devtools/url_constants.cc ('k') | chrome/browser/ui/webui/devtools_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/devtools_ui.h
diff --git a/chrome/browser/ui/webui/devtools_ui.h b/chrome/browser/ui/webui/devtools_ui.h
index 8e6328d8df993e54e6ed485985ddfbf443afa394..809e4e4f1a2e3fb9d441b637d258d5135b1de7f7 100644
--- a/chrome/browser/ui/webui/devtools_ui.h
+++ b/chrome/browser/ui/webui/devtools_ui.h
@@ -5,9 +5,6 @@
#ifndef CHROME_BROWSER_UI_WEBUI_DEVTOOLS_UI_H_
#define CHROME_BROWSER_UI_WEBUI_DEVTOOLS_UI_H_
-#include <memory>
-
-#include "base/compiler_specific.h"
#include "base/macros.h"
#include "chrome/browser/devtools/devtools_ui_bindings.h"
#include "content/public/browser/web_ui_controller.h"
@@ -16,13 +13,12 @@ class DevToolsUI : public content::WebUIController {
public:
static GURL GetProxyURL(const std::string& frontend_url);
static GURL GetRemoteBaseURL();
- static GURL SanitizeFrontendURL(const GURL& url);
explicit DevToolsUI(content::WebUI* web_ui);
~DevToolsUI() override;
private:
- std::unique_ptr<DevToolsUIBindings> bindings_;
+ DevToolsUIBindings bindings_;
DISALLOW_COPY_AND_ASSIGN(DevToolsUI);
};
« no previous file with comments | « chrome/browser/devtools/url_constants.cc ('k') | chrome/browser/ui/webui/devtools_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698