Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 260783002: Revert 267158 "CleanUp: Introduce UserInfo. Move session_state s..." (Closed)

Created:
6 years, 7 months ago by oshima
Modified:
6 years, 7 months ago
Reviewers:
oshima
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 267158 "CleanUp: Introduce UserInfo. Move session_state s..." > CleanUp: Introduce UserInfo. Move session_state stuff to ash/session. > > BUG=None > R=nkostylev@chromium.org > TBR=sky@chromium.org > > Review URL: https://codereview.chromium.org/253063002 TBR=oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267250

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+278 lines, -801 lines) Patch
M trunk/src/ash/accelerators/accelerator_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/ash/accelerators/nested_dispatcher_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/ash.gyp View 3 chunks +7 lines, -8 lines 0 comments Download
M trunk/src/ash/desktop_background/desktop_background_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/frame/custom_frame_view_ash.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/frame/frame_util.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M trunk/src/ash/root_window_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/root_window_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D trunk/src/ash/session/session_state_delegate.h View 1 chunk +0 lines, -140 lines 0 comments Download
D trunk/src/ash/session/session_state_delegate_stub.h View 1 chunk +0 lines, -58 lines 0 comments Download
D trunk/src/ash/session/session_state_delegate_stub.cc View 1 chunk +0 lines, -137 lines 0 comments Download
D trunk/src/ash/session/session_state_observer.h View 1 chunk +0 lines, -46 lines 0 comments Download
D trunk/src/ash/session/session_state_observer.cc View 1 chunk +0 lines, -25 lines 0 comments Download
D trunk/src/ash/session/user_info.h View 1 chunk +0 lines, -45 lines 0 comments Download
A + trunk/src/ash/session_state_delegate.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/session_state_delegate_stub.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/session_state_delegate_stub.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/session_state_observer.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ash/session_state_observer.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/ash/shelf/shelf_layout_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/shelf/shelf_layout_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/shelf/shelf_layout_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/shelf/shelf_widget.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/shell.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/shell/app_list.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/shell/lock_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/shell/shell_delegate_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/ash/shell/window_type_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/shell_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/system/chromeos/network/network_connect.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/system/chromeos/power/power_event_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/system/chromeos/session/logout_confirmation_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/system/date/date_default_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/system/tray/default_system_tray_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/system/user/accounts_detailed_view.cc View 3 chunks +5 lines, -9 lines 0 comments Download
M trunk/src/ash/system/user/config.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/system/user/login_status.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/system/user/tray_user.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/system/user/tray_user.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M trunk/src/ash/system/user/tray_user_separator.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/system/user/tray_user_unittest.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M trunk/src/ash/system/user/user_card_view.cc View 5 chunks +8 lines, -12 lines 0 comments Download
M trunk/src/ash/system/user/user_view.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/system/user/user_view.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M trunk/src/ash/test/test_session_state_delegate.h View 4 chunks +15 lines, -13 lines 0 comments Download
M trunk/src/ash/test/test_session_state_delegate.cc View 4 chunks +32 lines, -75 lines 0 comments Download
M trunk/src/ash/test/test_shell_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/test/test_system_tray_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/wm/event_client_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/wm/gestures/shelf_gesture_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/wm/lock_state_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/wm/mru_window_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/wm/overview/window_selector_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/wm/power_button_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/wm/stacking_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/wm/system_modal_container_layout_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/wm/system_modal_container_layout_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/wm/workspace/workspace_layout_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/wm/workspace/workspace_layout_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/chromeos/accessibility/accessibility_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/chromeos/accessibility/accessibility_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/chromeos/accessibility/magnification_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/chromeos/dbus/printer_service_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/chromeos/extensions/first_run_private_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/chromeos/login/session_login_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/chromeos/login/user.h View 4 chunks +11 lines, -10 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/login/user.cc View 3 chunks +0 lines, -18 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/login/user_adding_screen_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/chromeos/login/user_image_manager_browsertest.cc View 14 chunks +16 lines, -16 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/login/user_image_manager_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/chromeos/memory/oom_priority_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/chromeos/policy/device_local_account_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/chromeos/profiles/profile_list_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/idle_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/notifications/message_center_settings_controller.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/ui/ash/multi_user/multi_user_context_menu_chromeos.cc View 3 chunks +10 lines, -13 lines 0 comments Download
M trunk/src/chrome/browser/ui/ash/multi_user/multi_user_notification_blocker_chromeos_unittest.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/ui/ash/multi_user/multi_user_window_manager.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M trunk/src/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc View 7 chunks +7 lines, -12 lines 0 comments Download
M trunk/src/chrome/browser/ui/ash/session_state_delegate_chromeos.h View 2 chunks +10 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/ui/ash/session_state_delegate_chromeos.cc View 2 chunks +30 lines, -7 lines 0 comments Download
M trunk/src/chrome/browser/ui/ash/session_state_delegate_views.h View 2 chunks +10 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/ui/ash/session_state_delegate_views.cc View 2 chunks +29 lines, -44 lines 0 comments Download
M trunk/src/chrome/browser/ui/ash/system_tray_delegate_chromeos.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/browser_command_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/views/frame/browser_frame.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/ui/views/frame/system_menu_model_builder.cc View 2 chunks +7 lines, -8 lines 0 comments Download
M trunk/src/chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
oshima
6 years, 7 months ago (2014-04-30 17:12:37 UTC) #1
oshima
6 years, 7 months ago (2014-04-30 17:15:15 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r267250.

Powered by Google App Engine
This is Rietveld 408576698