Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 253063002: CleanUp: Introduce UserInfo. Move session_state stuff to ash/session. (Closed)

Created:
6 years, 7 months ago by oshima
Modified:
6 years, 7 months ago
Reviewers:
Nikita (slow), sky
CC:
chromium-reviews, dbeam+watch-options_chromium.org, dtseng+watch_chromium.org, sadrul, nkostylev+watch_chromium.org, derat+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, tdanderson+overview_chromium.org, yuzo+watch_chromium.org, rginda+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, tfarina, kalyank, stevenjb+watch_chromium.org, plundblad+watch_chromium.org, ben+ash_chromium.org, dmazzoni+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Total comments: 11

Patch Set 3 : #

Patch Set 4 : WIP #

Patch Set 5 : addressed comments #

Patch Set 6 : WIP #

Patch Set 7 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+507 lines, -777 lines) Patch
M ash/accelerators/accelerator_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/accelerators/nested_dispatcher_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/ash.gyp View 1 2 3 3 chunks +8 lines, -7 lines 0 comments Download
M ash/desktop_background/desktop_background_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/frame/custom_frame_view_ash.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/frame/frame_util.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M ash/root_window_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/root_window_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ash/session/session_state_delegate.h View 4 chunks +9 lines, -24 lines 0 comments Download
A + ash/session/session_state_delegate_stub.h View 1 2 3 3 chunks +10 lines, -17 lines 0 comments Download
A + ash/session/session_state_delegate_stub.cc View 1 2 3 2 chunks +45 lines, -30 lines 0 comments Download
A + ash/session/session_state_observer.h View 2 chunks +4 lines, -4 lines 0 comments Download
A ash/session/session_state_observer.cc View 1 chunk +25 lines, -0 lines 0 comments Download
A ash/session/user_info.h View 1 2 3 1 chunk +45 lines, -0 lines 0 comments Download
D ash/session_state_delegate.h View 1 chunk +0 lines, -155 lines 0 comments Download
D ash/session_state_delegate_stub.h View 1 chunk +0 lines, -65 lines 0 comments Download
D ash/session_state_delegate_stub.cc View 1 chunk +0 lines, -122 lines 0 comments Download
D ash/session_state_observer.h View 1 chunk +0 lines, -46 lines 0 comments Download
D ash/session_state_observer.cc View 1 chunk +0 lines, -24 lines 0 comments Download
M ash/shelf/shelf_layout_manager.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_layout_manager.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_layout_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_widget.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/app_list.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/lock_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/shell_delegate_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/shell/window_type_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/network/network_connect.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/power/power_event_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/session/logout_confirmation_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/date/date_default_view.cc View 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/default_system_tray_delegate.cc View 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/system/user/accounts_detailed_view.cc View 1 2 3 4 3 chunks +9 lines, -5 lines 0 comments Download
M ash/system/user/config.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/user/login_status.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/user/tray_user.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/user/tray_user.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ash/system/user/tray_user_separator.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/user/tray_user_unittest.cc View 1 2 3 4 2 chunks +5 lines, -2 lines 0 comments Download
M ash/system/user/user_card_view.cc View 5 chunks +12 lines, -8 lines 0 comments Download
M ash/system/user/user_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/user/user_view.cc View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
M ash/test/test_session_state_delegate.h View 1 2 3 4 5 4 chunks +13 lines, -15 lines 0 comments Download
M ash/test/test_session_state_delegate.cc View 1 2 3 4 5 4 chunks +75 lines, -32 lines 0 comments Download
M ash/test/test_shell_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/test/test_system_tray_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/event_client_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/gestures/shelf_gesture_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/lock_state_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/mru_window_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/overview/window_selector_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/power_button_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/stacking_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/system_modal_container_layout_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/system_modal_container_layout_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_layout_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_layout_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_manager.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/magnification_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/dbus/printer_service_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/first_run_private_api.cc View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/file_manager/file_manager_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/session_login_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/user.h View 1 2 3 4 chunks +10 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/login/user.cc View 1 2 3 4 5 6 3 chunks +17 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/user_adding_screen_browsertest.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/user_image_manager_browsertest.cc View 14 chunks +16 lines, -16 lines 0 comments Download
M chrome/browser/chromeos/login/user_image_manager_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/memory/oom_priority_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/device_local_account_browsertest.cc View 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/profiles/profile_list_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/idle_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/message_center_settings_controller.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc View 1 2 3 4 5 6 4 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_context_menu_chromeos.cc View 1 2 3 4 3 chunks +13 lines, -10 lines 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_notification_blocker_chromeos_unittest.cc View 1 2 3 4 5 6 3 chunks +12 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager.cc View 1 2 3 4 2 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc View 1 2 3 4 5 7 chunks +12 lines, -7 lines 0 comments Download
M chrome/browser/ui/ash/session_state_delegate_chromeos.h View 2 chunks +4 lines, -10 lines 0 comments Download
M chrome/browser/ui/ash/session_state_delegate_chromeos.cc View 2 chunks +7 lines, -30 lines 0 comments Download
M chrome/browser/ui/ash/session_state_delegate_views.h View 2 chunks +4 lines, -10 lines 0 comments Download
M chrome/browser/ui/ash/session_state_delegate_views.cc View 1 2 3 2 chunks +44 lines, -29 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.h View 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_command_controller.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_frame.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/system_menu_model_builder.cc View 2 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 32 (0 generated)
oshima
nikita, you take a first look? https://codereview.chromium.org/253063002/diff/50001/chrome/browser/ui/ash/session_state_delegate_chromeos.cc File chrome/browser/ui/ash/session_state_delegate_chromeos.cc (left): https://codereview.chromium.org/253063002/diff/50001/chrome/browser/ui/ash/session_state_delegate_chromeos.cc#oldcode139 chrome/browser/ui/ash/session_state_delegate_chromeos.cc:139: GetLRULoggedInUsers()[index]->display_name(); This now ...
6 years, 7 months ago (2014-04-29 02:11:50 UTC) #1
tfarina
s/Intorudce/Introduce
6 years, 7 months ago (2014-04-29 02:51:10 UTC) #2
Nikita (slow)
lgtm, thanks https://codereview.chromium.org/253063002/diff/70001/ash/session/session_state_delegate_stub.h File ash/session/session_state_delegate_stub.h (right): https://codereview.chromium.org/253063002/diff/70001/ash/session/session_state_delegate_stub.h#newcode50 ash/session/session_state_delegate_stub.h:50: scoped_ptr<UserInfo> user_info_; This is for the active ...
6 years, 7 months ago (2014-04-29 13:59:26 UTC) #3
oshima
https://codereview.chromium.org/253063002/diff/70001/ash/session/session_state_delegate_stub.h File ash/session/session_state_delegate_stub.h (right): https://codereview.chromium.org/253063002/diff/70001/ash/session/session_state_delegate_stub.h#newcode50 ash/session/session_state_delegate_stub.h:50: scoped_ptr<UserInfo> user_info_; On 2014/04/29 13:59:27, Nikita Kostylev wrote: > ...
6 years, 7 months ago (2014-04-29 17:59:53 UTC) #4
oshima
TBR'ing sky for trivial method/include renames in the following files. chrome/browser/idle_chromeos.cc chrome/browser/notifications/message_center_settings_controller.cc chrome/browser/ui/browser_command_controller.cc chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc chrome/browser/ui/views/frame/browser_frame.cc ...
6 years, 7 months ago (2014-04-29 18:00:57 UTC) #5
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 7 months ago (2014-04-29 18:01:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/253063002/150001
6 years, 7 months ago (2014-04-29 18:02:26 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 18:58:19 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium win_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-04-29 18:58:20 UTC) #9
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 7 months ago (2014-04-29 19:15:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/253063002/150001
6 years, 7 months ago (2014-04-29 19:16:04 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 21:56:43 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-04-29 21:56:44 UTC) #13
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 7 months ago (2014-04-30 10:05:44 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/253063002/230001
6 years, 7 months ago (2014-04-30 10:06:15 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 10:10:04 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium
6 years, 7 months ago (2014-04-30 10:10:05 UTC) #17
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 7 months ago (2014-04-30 10:13:16 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/253063002/230001
6 years, 7 months ago (2014-04-30 10:13:30 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 10:17:08 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium
6 years, 7 months ago (2014-04-30 10:17:09 UTC) #21
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 7 months ago (2014-04-30 10:19:39 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/253063002/230001
6 years, 7 months ago (2014-04-30 10:19:49 UTC) #23
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 10:25:57 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium
6 years, 7 months ago (2014-04-30 10:25:57 UTC) #25
oshima
On 2014/04/30 10:25:57, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 7 months ago (2014-04-30 10:32:12 UTC) #26
oshima
Committed patchset #6 manually as r267158 (presubmit successful).
6 years, 7 months ago (2014-04-30 10:33:58 UTC) #27
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 7 months ago (2014-04-30 17:56:37 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/253063002/250001
6 years, 7 months ago (2014-04-30 17:56:54 UTC) #29
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 18:04:51 UTC) #30
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium
6 years, 7 months ago (2014-04-30 18:04:51 UTC) #31
oshima
6 years, 7 months ago (2014-04-30 21:24:12 UTC) #32
Message was sent while issue was closed. 
Committed patchset #7 manually as r267337 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698