Remove context parameters from IntentHandler

Remove context parameters from IntentHandler

Methods of IntentHandler typically take a context, but the context is
merely used to get the package name and start an Activity.  We can
instead use ContextUtils.getApplicationContext().

Review-Url: https://codereview.chromium.org/2607633002
Cr-Commit-Position: refs/heads/master@{#441842}
Committed: https://chromium.googlesource.com/chromium/src/+/a75163e6ee0d3dcd5b929bbadcb5cd23bd15d636

[cco3, 2017-01-05 19:45:27]

cco3@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[gone, 2017-01-05 19:53:57]

dfalcantara@chromium.org changed reviewers:
+ yusufo@chromium.org

[gone, 2017-01-05 19:53:57]

Load balancing to Yusuf

[cco3, 2017-01-05 20:26:58]

On 2017/01/05 19:53:57, dfalcantara (check queue) wrote:
> Load balancing to Yusuf

Thanks, Dan!

[Yusuf, 2017-01-05 21:09:23]

lgtm with a nit

note to dfalcantara@:

One thing that I wanted to make sure was we are not changing any UI flows by
switching to app context in these calls which might have happened if we were
originally using activity for some startActivity call inside these.

All calls changed here calls/needs the context for three methods in the end.

getAuthenticationToken (which can use application context, the param name is
actually appContext even now),
startActivityForTrustedIntentInternal(calls startActivity after it does
context.getApplicationContext() now),
isIntentChromeOrFirstParty (Calls gmscore.isGoogleSigned which needs app
context).

So all seems safe.

https://codereview.chromium.org/2607633002/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java
(left):

https://codereview.chromium.org/2607633002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java:791:
mKeyguardManager = (KeyguardManager)
context.getSystemService(Context.KEYGUARD_SERVICE);
is there a reason why we don't want to cache this anymore? This seems fine, but
I wonder why we started caching this in the first place. Due to getSystemService
taking too long maybe?

[cco3, 2017-01-05 21:24:01]

https://codereview.chromium.org/2607633002/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java
(left):

https://codereview.chromium.org/2607633002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java:791:
mKeyguardManager = (KeyguardManager)
context.getSystemService(Context.KEYGUARD_SERVICE);
On 2017/01/05 21:09:22, Yusuf wrote:
> is there a reason why we don't want to cache this anymore? This seems fine,
but
> I wonder why we started caching this in the first place. Due to
getSystemService
> taking too long maybe?

I'm not intimately familiar with the code, but it just seemed unneeded.

jaekyun@, would you be able to comment?

[Jaekyun Seok (inactive), 2017-01-05 21:52:16]

Description was changed from

==========
Remove context parameters from IntentHandler

Methods of IntentHandler typically take a context, but the context is
merely used to get the package name and start an Activity.  We can
instead use ContextUtils.getApplicationContext().
==========

to

==========
Remove context parameters from IntentHandler

Methods of IntentHandler typically take a context, but the context is
merely used to get the package name and start an Activity.  We can
instead use ContextUtils.getApplicationContext().
==========

[Jaekyun Seok (inactive), 2017-01-05 21:54:00]

jaekyun@chromium.org changed reviewers:
+ jaekyun@chromium.org

[Jaekyun Seok (inactive), 2017-01-05 21:54:01]

https://codereview.chromium.org/2607633002/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java
(left):

https://codereview.chromium.org/2607633002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java:791:
mKeyguardManager = (KeyguardManager)
context.getSystemService(Context.KEYGUARD_SERVICE);
On 2017/01/05 21:24:01, cco3 wrote:
> On 2017/01/05 21:09:22, Yusuf wrote:
> > is there a reason why we don't want to cache this anymore? This seems fine,
> but
> > I wonder why we started caching this in the first place. Due to
> getSystemService
> > taking too long maybe?
> 
> I'm not intimately familiar with the code, but it just seemed unneeded.
> 
> jaekyun@, would you be able to comment?

Sorry, but I don't know about it.

Maria (mariakhomenko@), do you have any idea on this?

[Maria, 2017-01-05 22:39:48]

mariakhomenko@chromium.org changed reviewers:
+ mariakhomenko@chromium.org

[Maria, 2017-01-05 22:39:49]

lgtm

https://codereview.chromium.org/2607633002/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java
(left):

https://codereview.chromium.org/2607633002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java:791:
mKeyguardManager = (KeyguardManager)
context.getSystemService(Context.KEYGUARD_SERVICE);
On 2017/01/05 21:54:00, Jaekyun Seok (inactive) wrote:
> On 2017/01/05 21:24:01, cco3 wrote:
> > On 2017/01/05 21:09:22, Yusuf wrote:
> > > is there a reason why we don't want to cache this anymore? This seems
fine,
> > but
> > > I wonder why we started caching this in the first place. Due to
> > getSystemService
> > > taking too long maybe?
> > 
> > I'm not intimately familiar with the code, but it just seemed unneeded.
> > 
> > jaekyun@, would you be able to comment?
> 
> Sorry, but I don't know about it.
> 
> Maria (mariakhomenko@), do you have any idea on this?

I don't think it's needed -- we don't cache system services anywhere else. It
was written this way by the original author circa 2012 and I don't think there
was any specific reason they cached the service.

[cco3, 2017-01-05 22:43:26]

The CQ bit was checked by cco3@chromium.org

[commit-bot: I haz the power, 2017-01-05 22:44:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 22:46:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 22:46:23]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[cco3, 2017-01-05 23:06:04]

The CQ bit was checked by cco3@chromium.org

[cco3, 2017-01-05 23:06:04]

The patchset sent to the CQ was uploaded after l-g-t-m from yusufo@chromium.org,
mariakhomenko@chromium.org
Link to the patchset: https://codereview.chromium.org/2607633002/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2017-01-05 23:06:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 02:41:24]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483657564495520,
"parent_rev": "53d00d666c1fbd943a11b9b12a0e0817be654cfb", "commit_rev":
"a75163e6ee0d3dcd5b929bbadcb5cd23bd15d636"}

[commit-bot: I haz the power, 2017-01-06 02:41:51]

Description was changed from

==========
Remove context parameters from IntentHandler

Methods of IntentHandler typically take a context, but the context is
merely used to get the package name and start an Activity.  We can
instead use ContextUtils.getApplicationContext().
==========

to

==========
Remove context parameters from IntentHandler

Methods of IntentHandler typically take a context, but the context is
merely used to get the package name and start an Activity.  We can
instead use ContextUtils.getApplicationContext().

Review-Url: https://codereview.chromium.org/2607633002
Cr-Commit-Position: refs/heads/master@{#441842}
Committed:
https://chromium.googlesource.com/chromium/src/+/a75163e6ee0d3dcd5b929bbadcb5...
==========

[commit-bot: I haz the power, 2017-01-06 02:41:53]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a75163e6ee0d3dcd5b929bbadcb5...