Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2852)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

Issue 2607633002: Remove context parameters from IntentHandler (Closed)
Patch Set: Rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
index 7c09524aace87a747fb8016bb8a80c738e844b8d..f236889a2ef69ff92d9b6f8311343b5fc60f2b8b 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
@@ -443,7 +443,7 @@ public class CustomTabActivity extends ChromeActivity {
@Override
public boolean shouldIgnoreIntent(Intent intent) {
- return mIntentHandler.shouldIgnoreIntent(CustomTabActivity.this, intent);
+ return mIntentHandler.shouldIgnoreIntent(intent);
}
@Override
@@ -497,7 +497,7 @@ public class CustomTabActivity extends ChromeActivity {
CustomTabsConnection.getInstance(getApplication());
String url = getUrlToLoad();
// Get any referrer that has been explicitly set by the app.
- String referrerUrl = IntentHandler.getReferrerUrlIncludingExtraHeaders(getIntent(), this);
+ String referrerUrl = IntentHandler.getReferrerUrlIncludingExtraHeaders(getIntent());
if (referrerUrl == null) {
Referrer referrer = customTabsConnection.getReferrerForSession(mSession);
if (referrer != null) referrerUrl = referrer.getUrl();
@@ -637,19 +637,19 @@ public class CustomTabActivity extends ChromeActivity {
if (mHasPrerendered && UrlUtilities.urlsFragmentsDiffer(mPrerenderedUrl, url)) {
mHasPrerendered = false;
LoadUrlParams temporaryParams = new LoadUrlParams(mPrerenderedUrl);
- IntentHandler.addReferrerAndHeaders(temporaryParams, intent, this);
+ IntentHandler.addReferrerAndHeaders(temporaryParams, intent);
tab.loadUrl(temporaryParams);
params.setShouldReplaceCurrentEntry(true);
}
- IntentHandler.addReferrerAndHeaders(params, intent, this);
+ IntentHandler.addReferrerAndHeaders(params, intent);
if (params.getReferrer() == null) {
params.setReferrer(CustomTabsConnection.getInstance(getApplication())
.getReferrerForSession(mSession));
}
// See ChromeTabCreator#getTransitionType(). This marks the navigation chain as starting
// from an external intent (unless otherwise specified by an extra in the intent).
- params.setTransitionType(IntentHandler.getTransitionTypeFromIntent(this, intent,
+ params.setTransitionType(IntentHandler.getTransitionTypeFromIntent(intent,
PageTransition.LINK | PageTransition.FROM_API));
mTabObserver.trackNextPageLoadFromTimestamp(timeStamp);
tab.loadUrl(params);
@@ -941,7 +941,7 @@ public class CustomTabActivity extends ChromeActivity {
StrictMode.allowThreadDiskWrites();
try {
if (mIntentDataProvider.isInfoPage()) {
- IntentHandler.startChromeLauncherActivityForTrustedIntent(intent, this);
+ IntentHandler.startChromeLauncherActivityForTrustedIntent(intent);
} else {
startActivity(intent, startActivityOptions);
}
@@ -966,7 +966,7 @@ public class CustomTabActivity extends ChromeActivity {
/** Sets the initial background color for the Tab, shown before the page content is ready. */
private void prepareTabBackground(final Tab tab) {
- if (!IntentHandler.isIntentChromeOrFirstParty(getIntent(), this)) return;
+ if (!IntentHandler.isIntentChromeOrFirstParty(getIntent())) return;
int backgroundColor = mIntentDataProvider.getInitialBackgroundColor();
if (backgroundColor == Color.TRANSPARENT) return;
@@ -1021,7 +1021,7 @@ public class CustomTabActivity extends ChromeActivity {
intent.setPackage(context.getPackageName());
intent.putExtra(CustomTabIntentDataProvider.EXTRA_IS_INFO_PAGE, true);
intent.putExtra(Browser.EXTRA_APPLICATION_ID, context.getPackageName());
- IntentHandler.addTrustedIntentExtras(intent, context);
+ IntentHandler.addTrustedIntentExtras(intent);
context.startActivity(intent);
}

Powered by Google App Engine
This is Rietveld 408576698