[builtins] FastNewClosureStub becomes a builtin.

[builtins] FastNewClosureStub becomes a builtin.

This aids in TurboFan concurrent compilation, a general good.

TBR for Ross, on vacation...

TBR=rmcilroy@chromium.org

BUG=

Review-Url: https://codereview.chromium.org/2607563002
Cr-Commit-Position: refs/heads/master@{#41970}
Committed: https://chromium.googlesource.com/v8/v8/+/b063b34373bd4e7820d3f08e4281109588d66faf

[mvstanton, 2016-12-27 15:49:19]

The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-27 15:49:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mvstanton, 2016-12-27 15:51:01]

mvstanton@chromium.org changed reviewers:
+ danno@chromium.org

[mvstanton, 2016-12-27 15:51:02]

Hi Danno,
Here is the first of 4-5 "constructor stub" moves, into a new home in the
builtin-style. The rest will follow into this pattern.

The sadness is that CompileLazy had to be declared in a different place in
builtins.h. We should have a todo or tracking bug to make a better solution...
Thanks,
--Michael

[commit-bot: I haz the power, 2016-12-27 16:18:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-27 16:18:33]

Dry run: This issue passed the CQ dry run.

[mvstanton, 2016-12-28 09:08:22]

The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 09:08:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[danno, 2016-12-28 09:11:45]

lgtm with comments

https://codereview.chromium.org/2607563002/diff/40001/src/compiler/js-generic...
File src/compiler/js-generic-lowering.cc (right):

https://codereview.chromium.org/2607563002/diff/40001/src/compiler/js-generic...
src/compiler/js-generic-lowering.cc:347: // Use the FastNewClosureStub builtin
only for functions allocated in new
nit: remove Stub

https://codereview.chromium.org/2607563002/diff/40001/src/contexts.h
File src/contexts.h (right):

https://codereview.chromium.org/2607563002/diff/40001/src/contexts.h#newcode641
src/contexts.h:641: // Note: Must be kept in sync with the FastNewClosureStub
builtin.
nit: Remove Stub

[mvstanton, 2016-12-28 09:29:24]

Renames complete, thx!

https://codereview.chromium.org/2607563002/diff/40001/src/compiler/js-generic...
File src/compiler/js-generic-lowering.cc (right):

https://codereview.chromium.org/2607563002/diff/40001/src/compiler/js-generic...
src/compiler/js-generic-lowering.cc:347: // Use the FastNewClosureStub builtin
only for functions allocated in new
On 2016/12/28 09:11:45, danno wrote:
> nit: remove Stub

Done.

https://codereview.chromium.org/2607563002/diff/40001/src/contexts.h
File src/contexts.h (right):

https://codereview.chromium.org/2607563002/diff/40001/src/contexts.h#newcode641
src/contexts.h:641: // Note: Must be kept in sync with the FastNewClosureStub
builtin.
On 2016/12/28 09:11:45, danno wrote:
> nit: Remove Stub

Done.

[mvstanton, 2016-12-28 09:29:37]

The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 09:29:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mvstanton, 2016-12-28 09:50:09]

mvstanton@chromium.org changed reviewers:
+ epertoso@chromium.org, ishell@chromium.org

[mvstanton, 2016-12-28 09:50:09]

Hi Enrico, hi Igor,
Can you guys have a look too?
thx,
--Michael

[commit-bot: I haz the power, 2016-12-28 09:58:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 09:58:16]

Dry run: This issue passed the CQ dry run.

[epertoso, 2016-12-28 10:00:34]

lgtm for compiler/

[Igor Sheludko, 2016-12-28 10:01:37]

lgtm

[mvstanton, 2016-12-28 10:03:20]

The CQ bit was checked by mvstanton@chromium.org

[mvstanton, 2016-12-28 10:03:20]

The patchset sent to the CQ was uploaded after l-g-t-m from danno@chromium.org
Link to the patchset: https://codereview.chromium.org/2607563002/#ps60001
(title: "Renames.")

[commit-bot: I haz the power, 2016-12-28 10:03:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 10:06:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 10:06:14]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/31369)

[mvstanton, 2016-12-28 10:09:26]

Description was changed from

==========
[builtins] FastNewClosureStub becomes a builtin.

This aids in TurboFan concurrent compilation, a general good.

BUG=
==========

to

==========
[builtins] FastNewClosureStub becomes a builtin.

This aids in TurboFan concurrent compilation, a general good.

TBR for Ross, on vacation...

TBR=rmcilroy@chromium.org

BUG=
==========

[mvstanton, 2016-12-28 10:09:26]

mvstanton@chromium.org changed reviewers:
+ ross@kndr.org

[mvstanton, 2016-12-28 10:09:36]

The CQ bit was checked by mvstanton@chromium.org

[commit-bot: I haz the power, 2016-12-28 10:09:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 11:43:17]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1482919776502060,
"parent_rev": "ee1b69a480d734c15d98fccc024385e43bc65cbe", "commit_rev":
"b063b34373bd4e7820d3f08e4281109588d66faf"}

[commit-bot: I haz the power, 2016-12-28 11:43:22]

Description was changed from

==========
[builtins] FastNewClosureStub becomes a builtin.

This aids in TurboFan concurrent compilation, a general good.

TBR for Ross, on vacation...

TBR=rmcilroy@chromium.org

BUG=
==========

to

==========
[builtins] FastNewClosureStub becomes a builtin.

This aids in TurboFan concurrent compilation, a general good.

TBR for Ross, on vacation...

TBR=rmcilroy@chromium.org

BUG=

Review-Url: https://codereview.chromium.org/2607563002
Cr-Commit-Position: refs/heads/master@{#41970}
Committed:
https://chromium.googlesource.com/v8/v8/+/b063b34373bd4e7820d3f08e4281109588d...
==========

[commit-bot: I haz the power, 2016-12-28 11:43:23]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/b063b34373bd4e7820d3f08e4281109588d...