[builtins] FastNewFunctionContextStub becomes a builtin

[builtins] FastNewFunctionContextStub becomes a builtin

BUG=
TBR=rmcilroy@chromium.org

Review-Url: https://codereview.chromium.org/2604833004
Cr-Commit-Position: refs/heads/master@{#41988}
Committed: https://chromium.googlesource.com/v8/v8/+/f2e8c9786fdcc5f1cbb11676e9f4bfccada9b2d3

[mvstanton, 2016-12-28 10:58:20]

Description was changed from

==========
[builtins] FastNewFunctionContextStub becomes a builtin

BUG=
TBR=rmcilroy@chromium.org
==========

to

==========
[builtins] FastNewFunctionContextStub becomes a builtin

BUG=
TBR=rmcilroy@chromium.org
==========

[mvstanton, 2016-12-28 10:58:20]

mvstanton@chromium.org changed reviewers:
+ danno@chromium.org, epertoso@chromium.org

[mvstanton, 2016-12-28 10:58:20]

mvstanton@chromium.org changed required reviewers:
+ danno@chromium.org, epertoso@chromium.org

[mvstanton, 2016-12-28 10:58:53]

Hi Danno, hi Enrico,

I have to do more ports, but here is FastNewFunctionContext as a builtin. Thx
for the look!
--Michael

[mvstanton, 2016-12-28 11:20:10]

The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 11:20:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 11:24:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 11:24:04]

Dry run: Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)

[mvstanton, 2016-12-28 12:06:37]

The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 12:06:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 12:33:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 12:33:30]

Dry run: This issue passed the CQ dry run.

[mvstanton, 2016-12-28 14:48:29]

The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 14:48:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mvstanton, 2016-12-28 14:49:15]

Now updated to use static methods that *accept* an assembler, per our discussion
about the InterpreterAssembler issue.

[commit-bot: I haz the power, 2016-12-28 15:13:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 15:13:58]

Dry run: This issue passed the CQ dry run.

[danno, 2016-12-28 16:08:18]

Cool! OK, but it looks like Igor actually landed the change that moves the
InterpreterAssembler hooks into the State object so that you could use the
original scheme discussed this morning. wdyt? Shall I wait until you can rebase
on his work?

[mvstanton, 2016-12-29 06:14:47]

Ha! Wow, he's fast. Sure, let me switch back to the previous style then and then
I'll resubmit.

[mvstanton, 2016-12-29 08:12:34]

The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-29 08:12:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mvstanton, 2016-12-29 08:13:00]

Hi Danno, hi Enrico,
Okay, now this one is ready.
Thanks,
--Michael

[commit-bot: I haz the power, 2016-12-29 08:41:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-29 08:41:20]

Dry run: This issue passed the CQ dry run.

[danno, 2016-12-29 10:19:29]

lgtm with nit

https://codereview.chromium.org/2604833004/diff/80001/src/builtins/builtins.h
File src/builtins/builtins.h (right):

https://codereview.chromium.org/2604833004/diff/80001/src/builtins/builtins.h...
src/builtins/builtins.h:92: TFS(FastNewFunctionContext_Eval, BUILTIN,
kNoExtraICState,                   \
total nit, but not many of the other builtins have a _ in their name.

[epertoso, 2016-12-29 10:21:32]

lgtm for compiler/

[mvstanton, 2016-12-29 11:10:29]

The CQ bit was checked by mvstanton@chromium.org

[mvstanton, 2016-12-29 11:10:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
epertoso@chromium.org, danno@chromium.org
Link to the patchset: https://codereview.chromium.org/2604833004/#ps100001
(title: "nit.")

[mvstanton, 2016-12-29 11:10:33]

thanks!

https://codereview.chromium.org/2604833004/diff/80001/src/builtins/builtins.h
File src/builtins/builtins.h (right):

https://codereview.chromium.org/2604833004/diff/80001/src/builtins/builtins.h...
src/builtins/builtins.h:92: TFS(FastNewFunctionContext_Eval, BUILTIN,
kNoExtraICState,                   \
On 2016/12/29 10:19:29, danno wrote:
> total nit, but not many of the other builtins have a _ in their name.

Done.

[commit-bot: I haz the power, 2016-12-29 11:10:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-29 11:12:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-29 11:12:04]

Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/31429)
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/20129)

[mvstanton, 2016-12-29 11:22:17]

The CQ bit was checked by mvstanton@chromium.org

[mvstanton, 2016-12-29 11:22:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
epertoso@chromium.org, danno@chromium.org
Link to the patchset: https://codereview.chromium.org/2604833004/#ps120001
(title: "REBASE.")

[commit-bot: I haz the power, 2016-12-29 11:22:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-29 11:52:41]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1483010537989510,
"parent_rev": "350d8e345ec690997521b30a5f2ea73e98e0bd24", "commit_rev":
"f2e8c9786fdcc5f1cbb11676e9f4bfccada9b2d3"}

[commit-bot: I haz the power, 2016-12-29 11:52:47]

Description was changed from

==========
[builtins] FastNewFunctionContextStub becomes a builtin

BUG=
TBR=rmcilroy@chromium.org
==========

to

==========
[builtins] FastNewFunctionContextStub becomes a builtin

BUG=
TBR=rmcilroy@chromium.org

Review-Url: https://codereview.chromium.org/2604833004
Cr-Commit-Position: refs/heads/master@{#41988}
Committed:
https://chromium.googlesource.com/v8/v8/+/f2e8c9786fdcc5f1cbb11676e9f4bfccada...
==========

[commit-bot: I haz the power, 2016-12-29 11:52:48]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/v8/v8/+/f2e8c9786fdcc5f1cbb11676e9f4bfccada...

[rmcilroy, 2017-01-03 09:26:51]

Belated LGTM, thanks.