Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2606843002: Improve memory usage of safe browsing navigation oberver manager. (Closed)

Created:
3 years, 12 months ago by Jialiu Lin
Modified:
3 years, 11 months ago
Reviewers:
manoranjanr
CC:
chromium-reviews, grt+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve memory usage of safe browsing navigation oberver manager. (And add a TODO for PPAPI download attribution) BUG=676691 Committed: https://crrev.com/1dbe99496e0bc1ef47989bfd5eb99ae85470d4ea Cr-Commit-Position: refs/heads/master@{#440860}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M chrome/browser/safe_browsing/download_protection_service.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
Jialiu Lin
Hi manoranjanr@, All my other teammates are OOO during the holidays. Fortunately, I am on ...
3 years, 12 months ago (2016-12-28 00:45:40 UTC) #6
manoranjanr
On 2016/12/28 00:45:40, Jialiu Lin wrote: > Hi manoranjanr@, > All my other teammates are ...
3 years, 12 months ago (2016-12-28 01:02:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2606843002/1
3 years, 11 months ago (2016-12-28 17:16:09 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2016-12-28 17:20:36 UTC) #12
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:49:21 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1dbe99496e0bc1ef47989bfd5eb99ae85470d4ea
Cr-Commit-Position: refs/heads/master@{#440860}

Powered by Google App Engine
This is Rietveld 408576698