chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.cc - Issue 2606843002: Improve memory usage of safe browsing navigation oberver manager.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.cc

Issue 2606843002: Improve memory usage of safe browsing navigation oberver manager. (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/safe_browsing/download_protection_service.cc ('k') | no next file » | no next file with comments »

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager .h"	5 #include "chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager .h"

6	6

7 #include "base/memory/ptr_util.h"	7 #include "base/memory/ptr_util.h"

8 #include "base/metrics/histogram_macros.h"	8 #include "base/metrics/histogram_macros.h"

9 #include "base/strings/stringprintf.h"	9 #include "base/strings/stringprintf.h"

10 #include "base/time/time.h"	10 #include "base/time/time.h"

(...skipping 376 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
387 // referrer of the landing referrer page.	387 // referrer of the landing referrer page.

388 if (type != ReferrerChainEntry::LANDING_REFERRER) {	388 if (type != ReferrerChainEntry::LANDING_REFERRER) {

389 referrer_chain_entry.set_referrer_url(nav_event->source_url.spec());	389 referrer_chain_entry.set_referrer_url(nav_event->source_url.spec());

390 referrer_chain_entry.set_referrer_main_frame_url(	390 referrer_chain_entry.set_referrer_main_frame_url(

391 nav_event->source_main_frame_url.spec());	391 nav_event->source_main_frame_url.spec());

392 }	392 }

393 referrer_chain_entry.set_is_retargeting(nav_event->source_tab_id !=	393 referrer_chain_entry.set_is_retargeting(nav_event->source_tab_id !=

394 nav_event->target_tab_id);	394 nav_event->target_tab_id);

395 referrer_chain_entry.set_navigation_time_msec(	395 referrer_chain_entry.set_navigation_time_msec(

396 nav_event->last_updated.ToJavaTime());	396 nav_event->last_updated.ToJavaTime());

397 referrer_chain->push_back(referrer_chain_entry);	397 referrer_chain->push_back(std::move(referrer_chain_entry));

398 }	398 }

399	399

400 } // namespace safe_browsing	400 } // namespace safe_browsing

OLD	NEW