Remove base::ScopedPtrHashMap from device/.

Remove base::ScopedPtrHashMap from device/.

BUG=579229
Committed: https://crrev.com/15b1f5307b13a30002693aa1907819c447db4954
Cr-Commit-Position: refs/heads/master@{#440902}

[Avi (use Gerrit), 2016-12-27 22:46:21]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-27 22:46:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-27 22:59:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-27 22:59:23]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Avi (use Gerrit), 2016-12-27 23:30:19]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-27 23:30:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-27 23:41:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-27 23:41:44]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Avi (use Gerrit), 2016-12-27 23:59:38]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-27 23:59:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 00:12:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 00:12:09]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Avi (use Gerrit), 2016-12-28 00:17:30]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 00:17:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 00:51:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 00:51:53]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Avi (use Gerrit), 2016-12-28 17:33:17]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 17:33:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 18:16:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 18:16:07]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Avi (use Gerrit), 2016-12-28 18:23:11]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-28 18:23:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 21:46:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-28 21:46:25]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2016-12-28 21:54:08]

avi@chromium.org changed reviewers:
+ ortuno@chromium.org, reillyg@chromium.org, rockot@chromium.org,
scheib@chromium.org

[Avi (use Gerrit), 2016-12-28 21:54:08]

To any reviewer in the office.

[Ken Rockot(use gerrit already), 2016-12-28 22:19:25]

Woohoo! LGTM

[Avi (use Gerrit), 2016-12-28 22:22:42]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2016-12-28 22:22:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-28 22:26:44]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1482963762075820,
"parent_rev": "96a03064dd089e0e8c94ac2b183c33408727267f", "commit_rev":
"2e6562507d94275de62a9d66b5d90b8d8f6dca33"}

[commit-bot: I haz the power, 2016-12-28 22:27:13]

Description was changed from

==========
Remove base::ScopedPtrHashMap from device/.

BUG=579229
==========

to

==========
Remove base::ScopedPtrHashMap from device/.

BUG=579229

Review-Url: https://codereview.chromium.org/2606823002
==========

[commit-bot: I haz the power, 2016-12-28 22:27:14]

Committed patchset #6 (id:100001)

[Reilly Grant (use Gerrit), 2016-12-28 22:48:02]

I was too slow, still, some nits.

https://codereview.chromium.org/2606823002/diff/100001/device/bluetooth/bluet...
File device/bluetooth/bluetooth_device_android.cc (right):

https://codereview.chromium.org/2606823002/diff/100001/device/bluetooth/bluet...
device/bluetooth/bluetooth_device_android.cc:249: if
(gatt_services_.find(instance_id_string) != gatt_services_.end())
if (base::ContainsKey(gatt_services_, instance_id_string))

https://codereview.chromium.org/2606823002/diff/100001/device/bluetooth/bluet...
File device/bluetooth/bluetooth_device_win.cc (right):

https://codereview.chromium.org/2606823002/diff/100001/device/bluetooth/bluet...
device/bluetooth/bluetooth_device_win.cc:242:
std::unique_ptr<BluetoothServiceRecordWin> service_record =
auto service_record =

https://codereview.chromium.org/2606823002/diff/100001/device/bluetooth/bluet...
File device/bluetooth/bluetooth_remote_gatt_characteristic_android.cc (right):

https://codereview.chromium.org/2606823002/diff/100001/device/bluetooth/bluet...
device/bluetooth/bluetooth_remote_gatt_characteristic_android.cc:244:
DCHECK(descriptors_.find(instanceIdString) == descriptors_.end());
DCHECK(!base::ContainsKey(descriptors_, instanceIdString));

https://codereview.chromium.org/2606823002/diff/100001/device/bluetooth/bluet...
File device/bluetooth/bluetooth_remote_gatt_service_android.cc (right):

https://codereview.chromium.org/2606823002/diff/100001/device/bluetooth/bluet...
device/bluetooth/bluetooth_remote_gatt_service_android.cc:169:
DCHECK(characteristics_.find(instance_id_string) == characteristics_.end());
!base::ContainsKey

[commit-bot: I haz the power, 2017-01-02 15:50:35]

Description was changed from

==========
Remove base::ScopedPtrHashMap from device/.

BUG=579229

Review-Url: https://codereview.chromium.org/2606823002
==========

to

==========
Remove base::ScopedPtrHashMap from device/.

BUG=579229

Committed: https://crrev.com/15b1f5307b13a30002693aa1907819c447db4954
Cr-Commit-Position: refs/heads/master@{#440902}
==========

[commit-bot: I haz the power, 2017-01-02 15:50:36]

Patchset 6 (id:??) landed as
https://crrev.com/15b1f5307b13a30002693aa1907819c447db4954
Cr-Commit-Position: refs/heads/master@{#440902}

[Avi (use Gerrit), 2017-01-02 19:42:26]

https://codereview.chromium.org/2606823002/diff/100001/device/bluetooth/bluet...
File device/bluetooth/bluetooth_device_android.cc (right):

https://codereview.chromium.org/2606823002/diff/100001/device/bluetooth/bluet...
device/bluetooth/bluetooth_device_android.cc:249: if
(gatt_services_.find(instance_id_string) != gatt_services_.end())
On 2016/12/28 22:48:01, Reilly Grant wrote:
> if (base::ContainsKey(gatt_services_, instance_id_string))

Done.

https://codereview.chromium.org/2606823002/diff/100001/device/bluetooth/bluet...
File device/bluetooth/bluetooth_device_win.cc (right):

https://codereview.chromium.org/2606823002/diff/100001/device/bluetooth/bluet...
device/bluetooth/bluetooth_device_win.cc:242:
std::unique_ptr<BluetoothServiceRecordWin> service_record =
On 2016/12/28 22:48:01, Reilly Grant wrote:
> auto service_record = 

Done.

https://codereview.chromium.org/2606823002/diff/100001/device/bluetooth/bluet...
File device/bluetooth/bluetooth_remote_gatt_characteristic_android.cc (right):

https://codereview.chromium.org/2606823002/diff/100001/device/bluetooth/bluet...
device/bluetooth/bluetooth_remote_gatt_characteristic_android.cc:244:
DCHECK(descriptors_.find(instanceIdString) == descriptors_.end());
On 2016/12/28 22:48:01, Reilly Grant wrote:
> DCHECK(!base::ContainsKey(descriptors_, instanceIdString));

Done.

https://codereview.chromium.org/2606823002/diff/100001/device/bluetooth/bluet...
File device/bluetooth/bluetooth_remote_gatt_service_android.cc (right):

https://codereview.chromium.org/2606823002/diff/100001/device/bluetooth/bluet...
device/bluetooth/bluetooth_remote_gatt_service_android.cc:169:
DCHECK(characteristics_.find(instance_id_string) == characteristics_.end());
On 2016/12/28 22:48:01, Reilly Grant wrote:
> !base::ContainsKey

Done.