Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1521)

Unified Diff: device/bluetooth/bluetooth_device.h

Issue 2606823002: Remove base::ScopedPtrHashMap from device/. (Closed)
Patch Set: one last fix Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/bluetooth/bluetooth_device.h
diff --git a/device/bluetooth/bluetooth_device.h b/device/bluetooth/bluetooth_device.h
index 81021520b6501190cb165c7b32da3b2a4fedef77..296449601cb9c683fa572e1031d664412323da78 100644
--- a/device/bluetooth/bluetooth_device.h
+++ b/device/bluetooth/bluetooth_device.h
@@ -16,21 +16,21 @@
#include <vector>
#include "base/callback.h"
-#include "base/containers/scoped_ptr_hash_map.h"
#include "base/gtest_prod_util.h"
+#include "base/macros.h"
#include "base/memory/ref_counted.h"
#include "base/optional.h"
#include "base/strings/string16.h"
#include "base/time/time.h"
#include "device/bluetooth/bluetooth_common.h"
#include "device/bluetooth/bluetooth_export.h"
+#include "device/bluetooth/bluetooth_remote_gatt_service.h"
#include "device/bluetooth/bluetooth_uuid.h"
namespace device {
class BluetoothAdapter;
class BluetoothGattConnection;
-class BluetoothRemoteGattService;
class BluetoothSocket;
class BluetoothUUID;
@@ -106,8 +106,8 @@ class DEVICE_BLUETOOTH_EXPORT BluetoothDevice {
// Mapping from the platform-specific GATT service identifiers to
// BluetoothRemoteGattService objects.
- typedef base::ScopedPtrHashMap<std::string,
- std::unique_ptr<BluetoothRemoteGattService>>
+ typedef std::unordered_map<std::string,
+ std::unique_ptr<BluetoothRemoteGattService>>
GattServiceMap;
// Interface for negotiating pairing of bluetooth devices.
@@ -579,6 +579,9 @@ class DEVICE_BLUETOOTH_EXPORT BluetoothDevice {
DeviceUUIDs();
~DeviceUUIDs();
+ DeviceUUIDs(const DeviceUUIDs& other);
+ DeviceUUIDs& operator=(const DeviceUUIDs& other);
+
// Advertised Service UUIDs functions
void ReplaceAdvertisedUUIDs(UUIDList new_advertised_uuids);
@@ -601,7 +604,7 @@ class DEVICE_BLUETOOTH_EXPORT BluetoothDevice {
BluetoothDevice::UUIDSet device_uuids_;
};
- BluetoothDevice(BluetoothAdapter* adapter);
+ explicit BluetoothDevice(BluetoothAdapter* adapter);
// Implements platform specific operations to initiate a GATT connection.
// Subclasses must also call DidConnectGatt, DidFailToConnectGatt, or
@@ -673,6 +676,8 @@ class DEVICE_BLUETOOTH_EXPORT BluetoothDevice {
// Returns a localized string containing the device's bluetooth address and
// a device type for display when |name_| is empty.
base::string16 GetAddressWithLocalizedDeviceTypeName() const;
+
+ DISALLOW_COPY_AND_ASSIGN(BluetoothDevice);
};
} // namespace device

Powered by Google App Engine
This is Rietveld 408576698