Remove disable-policy-key-verification command line flag

Remove disable-policy-key-verification command line flag

This flag can be removed because all policy test servers provide
verification signatures.

BUG=275291
Review-Url: https://codereview.chromium.org/2606423002
Cr-Commit-Position: refs/heads/master@{#442865}
Committed: https://chromium.googlesource.com/chromium/src/+/16e3f3b70eefd21e2377c9f4149d875d3e638d22

[pmarko, 2017-01-03 20:33:51]

pmarko@chromium.org changed reviewers:
+ alemate@chromium.org, pastarmovj@chromium.org

[pmarko, 2017-01-03 20:33:51]

alemate@chromium.org: Please review changes in chrome/browser/chromeos/login.

pastarmovj@chromium.org: Please review changes in components/policy.

[pastarmovj, 2017-01-04 10:36:17]

lgtm with a nit.

https://codereview.chromium.org/2606423002/diff/1/components/policy/core/comm...
File components/policy/core/common/cloud/cloud_policy_validator.cc (right):

https://codereview.chromium.org/2606423002/diff/1/components/policy/core/comm...
components/policy/core/common/cloud/cloud_policy_validator.cc:38:
METRIC_POLICY_KEY_VERIFICATION_KEY_MISSING,
You can still rename it with a _DEPRECATED suffix.

[pmarko, 2017-01-04 13:50:22]

PTAL

https://codereview.chromium.org/2606423002/diff/1/components/policy/core/comm...
File components/policy/core/common/cloud/cloud_policy_constants.cc (right):

https://codereview.chromium.org/2606423002/diff/1/components/policy/core/comm...
components/policy/core/common/cloud/cloud_policy_constants.cc:101: std::string
GetPolicyVerificationKey() {
Do you think that we should still expose this as a std::string returning
function (even though there's nothing dynamic inside anymore), or rather expose
the array and a separate size constant?
(or even as a std::array but I haven't seen a precedent for this)

https://codereview.chromium.org/2606423002/diff/1/components/policy/core/comm...
File components/policy/core/common/cloud/cloud_policy_validator.cc (right):

https://codereview.chromium.org/2606423002/diff/1/components/policy/core/comm...
components/policy/core/common/cloud/cloud_policy_validator.cc:38:
METRIC_POLICY_KEY_VERIFICATION_KEY_MISSING,
On 2017/01/04 10:36:17, pastarmovj wrote:
> You can still rename it with a _DEPRECATED suffix.

Done.

[pastarmovj, 2017-01-04 14:37:27]

https://codereview.chromium.org/2606423002/diff/1/components/policy/core/comm...
File components/policy/core/common/cloud/cloud_policy_constants.cc (right):

https://codereview.chromium.org/2606423002/diff/1/components/policy/core/comm...
components/policy/core/common/cloud/cloud_policy_constants.cc:101: std::string
GetPolicyVerificationKey() {
I think this function is still useful utility for getting the key in a more
usable form.

Dunno if std::array will do with the POD only constants rule in the style guide.

[pmarko, 2017-01-04 14:51:39]

On 2017/01/04 14:37:27, pastarmovj wrote:
>
https://codereview.chromium.org/2606423002/diff/1/components/policy/core/comm...
> File components/policy/core/common/cloud/cloud_policy_constants.cc (right):
> 
>
https://codereview.chromium.org/2606423002/diff/1/components/policy/core/comm...
> components/policy/core/common/cloud/cloud_policy_constants.cc:101: std::string
> GetPolicyVerificationKey() {
> I think this function is still useful utility for getting the key in a more
> usable form.
> 
> Dunno if std::array will do with the POD only constants rule in the style
guide.

Hm, after reading some discussions in C-users about this topic which don't
clearly result in "yes, std::array can be treated
as a POD", I'm just going to leave this as it is.

[Alexander Alekseev, 2017-01-10 19:36:02]

lgtm

[pmarko, 2017-01-11 09:48:58]

The CQ bit was checked by pmarko@chromium.org

[pmarko, 2017-01-11 09:48:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
pastarmovj@chromium.org
Link to the patchset: https://codereview.chromium.org/2606423002/#ps20001
(title: "Rename deprecated constant")

[commit-bot: I haz the power, 2017-01-11 09:49:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 10:57:37]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484128138869800,
"parent_rev": "e8a0940aae4094d975ccc14f7398154b80e8b42a", "commit_rev":
"16e3f3b70eefd21e2377c9f4149d875d3e638d22"}

[commit-bot: I haz the power, 2017-01-11 10:58:05]

Description was changed from

==========
Remove disable-policy-key-verification command line flag

This flag can be removed because all policy test servers provide
verification signatures.

BUG=275291
==========

to

==========
Remove disable-policy-key-verification command line flag

This flag can be removed because all policy test servers provide
verification signatures.

BUG=275291

Review-Url: https://codereview.chromium.org/2606423002
Cr-Commit-Position: refs/heads/master@{#442865}
Committed:
https://chromium.googlesource.com/chromium/src/+/16e3f3b70eefd21e2377c9f4149d...
==========

[commit-bot: I haz the power, 2017-01-11 10:58:06]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/16e3f3b70eefd21e2377c9f4149d...