Remove disable-policy-key-verification command line flag

components/policy/core/common/cloud/cloud_policy_constants.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/policy/core/common/cloud/cloud_policy_constants.h"
 
 #include <stdint.h>
 
 #include "base/command_line.h"
 #include "base/logging.h"
@@ skipping 80 matching lines @@
     0x13, 0x04, 0x57, 0xC5, 0x85, 0xB6, 0x2A, 0x0F, 0x02, 0x46, 0x0D, 0x2D,
     0xCA, 0xE3, 0x3F, 0x84, 0x9E, 0x8B, 0x8A, 0x5F, 0xFC, 0x4D, 0xAA, 0xBE,
     0xBD, 0xE6, 0x64, 0x9F, 0x26, 0x9A, 0x2B, 0x97, 0x69, 0xA9, 0xBA, 0x0B,
     0xBD, 0x48, 0xE4, 0x81, 0x6B, 0xD4, 0x4B, 0x78, 0xE6, 0xAF, 0x95, 0x66,
     0xC1, 0x23, 0xDA, 0x23, 0x45, 0x36, 0x6E, 0x25, 0xF3, 0xC7, 0xC0, 0x61,
     0xFC, 0xEC, 0x66, 0x9D, 0x31, 0xD4, 0xD6, 0xB6, 0x36, 0xE3, 0x7F, 0x81,
     0x87, 0x02, 0x03, 0x01, 0x00, 0x01};
 
 const char kPolicyVerificationKeyHash[] = "1:356l7w";
 
 std::string GetPolicyVerificationKey() {

[pmarko, 2017/01/04 13:50:22]

Do you think that we should still expose this as a std::string returning
function (even though there's nothing dynamic inside anymore), or rather expose
the array and a separate size constant?
(or even as a std::array but I haven't seen a precedent for this)

[pastarmovj, 2017/01/04 14:37:27]

I think this function is still useful utility for getting the key in a more
usable form.

Dunno if std::array will do with the POD only constants rule in the style guide.

-  base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
-  if (command_line->HasSwitch(switches::kDisablePolicyKeyVerification)) {
-    return std::string();
-  } else {
-    return std::string(reinterpret_cast<const char*>(kPolicyVerificationKey),
-                       sizeof(kPolicyVerificationKey));
-  }
+  return std::string(reinterpret_cast<const char*>(kPolicyVerificationKey),
+                     sizeof(kPolicyVerificationKey));
 }
 
 }  // namespace policy