Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(846)

Issue 2606233002: Reland "Disable the CompilerDispatcher if we don't have idle time" (Closed)

Created:
3 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
3 years, 11 months ago
Reviewers:
marja
CC:
Michael Hablich, v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland "Disable the CompilerDispatcher if we don't have idle time" Original issue's description: > Disable the CompilerDispatcher if we don't have idle time > > Since we can't do all steps on background threads, we need idle time to > work > > BUG=v8:5215 > R=danno@chromium.org > > Review-Url: https://codereview.chromium.org/2600743002 > Cr-Commit-Position: refs/heads/master@{#41944} > Committed: https://chromium.googlesource.com/v8/v8/+/a0d9eb346bba90aa0b32a 2d3184cbbfd6adb243e BUG=v8:5215 Review-Url: https://codereview.chromium.org/2606233002 Cr-Commit-Position: refs/heads/master@{#42009} Committed: https://chromium.googlesource.com/v8/v8/+/09cb6efd588521ef95c6fa7ba2c3e18331648ea0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -2 lines) Patch
M src/compiler-dispatcher/compiler-dispatcher.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler-dispatcher/compiler-dispatcher.cc View 3 chunks +8 lines, -1 line 0 comments Download
M src/flag-definitions.h View 2 chunks +4 lines, -0 lines 0 comments Download
M test/unittests/compiler-dispatcher/compiler-dispatcher-unittest.cc View 1 chunk +23 lines, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
jochen (gone - plz use gerrit)
ptal the original version was reverted because v8_win_dbg timed out. I added this trybot, and ...
3 years, 11 months ago (2017-01-02 12:47:26 UTC) #4
marja
lgtm
3 years, 11 months ago (2017-01-02 12:48:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2606233002/1
3 years, 11 months ago (2017-01-02 12:53:29 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 12:59:17 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/09cb6efd588521ef95c6fa7ba2c3e183316...

Powered by Google App Engine
This is Rietveld 408576698