Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2600743002: Disable the CompilerDispatcher if we don't have idle time (Closed)

Created:
3 years, 12 months ago by jochen (gone - plz use gerrit)
Modified:
3 years, 12 months ago
Reviewers:
danno
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Disable the CompilerDispatcher if we don't have idle time Since we can't do all steps on background threads, we need idle time to work BUG=v8:5215 R=danno@chromium.org Review-Url: https://codereview.chromium.org/2600743002 Cr-Commit-Position: refs/heads/master@{#41944} Committed: https://chromium.googlesource.com/v8/v8/+/a0d9eb346bba90aa0b32a2d3184cbbfd6adb243e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -2 lines) Patch
M src/compiler-dispatcher/compiler-dispatcher.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler-dispatcher/compiler-dispatcher.cc View 3 chunks +8 lines, -1 line 0 comments Download
M src/flag-definitions.h View 2 chunks +4 lines, -0 lines 0 comments Download
M test/unittests/compiler-dispatcher/compiler-dispatcher-unittest.cc View 1 chunk +24 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
jochen (gone - plz use gerrit)
3 years, 12 months ago (2016-12-23 14:41:29 UTC) #1
danno
lgtm
3 years, 12 months ago (2016-12-23 14:58:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2600743002/1
3 years, 12 months ago (2016-12-23 15:01:39 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/a0d9eb346bba90aa0b32a2d3184cbbfd6adb243e
3 years, 12 months ago (2016-12-23 15:11:20 UTC) #10
Michael Achenbach
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2600773002/ by machenbach@chromium.org. ...
3 years, 12 months ago (2016-12-23 19:03:30 UTC) #11
Michael Achenbach
3 years, 12 months ago (2016-12-23 21:29:58 UTC) #12
Message was sent while issue was closed.
On 2016/12/23 19:03:30, Michael Achenbach (OOO) wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/2600773002/ by mailto:machenbach@chromium.org.
> 
> The reason for reverting is: [Sheriff] Speculative revert since we got
> persistent timeouts on win32 debug:
>
https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug/builds...
> 
> Please reland if it doesn't help..

Looks like the revert helped. In the output of the hanging shard the last
executed test is:
unittests/CompilerDispatcherTest.IdleTaskException: FAIL
But it also seems to hang on another test, but gets killed by the overall
timeout before we see which one.

Powered by Google App Engine
This is Rietveld 408576698