Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2606183002: Fix build of own emoji functions (Closed)

Created:
3 years, 11 months ago by drott
Modified:
3 years, 11 months ago
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix build of own emoji functions The UnicodeSet::applyPattern method accepts a UErrorCode& reference. Adding an automatic conversion operator to ICUError to fix the build when the built-in emoji functions are used. BUG=677658 Committed: https://crrev.com/8d86b413cc000d9f411b9d27636b1435bd9cc0dd Cr-Commit-Position: refs/heads/master@{#441061}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
M third_party/WebKit/Source/platform/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/text/CharacterEmoji.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/text/ICUError.h View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/text/ICUErrorTest.cpp View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
drott
3 years, 11 months ago (2016-12-30 14:02:47 UTC) #4
Paweł Hajdan Jr.
LGTM, thanks! FWIW the link to my attempt to fix this which led to this ...
3 years, 11 months ago (2016-12-30 16:47:37 UTC) #7
kojii
lgtm, thanks from me too.
3 years, 11 months ago (2017-01-02 09:24:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2606183002/1
3 years, 11 months ago (2017-01-02 11:08:08 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-02 12:56:29 UTC) #13
drott
Thanks for the review, Koji and Phajdan. Phajdan, if you comment on the Gentoo bug ...
3 years, 11 months ago (2017-01-02 13:00:56 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:55:23 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8d86b413cc000d9f411b9d27636b1435bd9cc0dd
Cr-Commit-Position: refs/heads/master@{#441061}

Powered by Google App Engine
This is Rietveld 408576698