third_party/WebKit/Source/platform/text/CharacterEmoji.cpp - Issue 2606183002: Fix build of own emoji functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/text/CharacterEmoji.cpp

Issue 2606183002: Fix build of own emoji functions (Closed)

Patch Set: Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/text/CharacterEmoji.cpp

diff --git a/third_party/WebKit/Source/platform/text/CharacterEmoji.cpp b/third_party/WebKit/Source/platform/text/CharacterEmoji.cpp

index 3310ac8b6c58be347f96e92899cb52e5e47b8d1a..21bcdf33993504609eb87a3df7bcc0af25651114 100644

--- a/third_party/WebKit/Source/platform/text/CharacterEmoji.cpp

+++ b/third_party/WebKit/Source/platform/text/CharacterEmoji.cpp

@@ -233,7 +233,7 @@ bool Character::isEmojiEmojiDefault(UChar32 ch) {

bool Character::isEmojiModifierBase(UChar32 ch) {

return u_hasBinaryProperty(ch, UCHAR_EMOJI_MODIFIER_BASE);

}

-#endif // defined(USING_SYSTEM_ICU) && (U_ICU_VERSION_MAJOR_NUM <= 56)

+#endif // defined(USING_SYSTEM_ICU) && (U_ICU_VERSION_MAJOR_NUM <= 57)

bool Character::isEmojiKeycapBase(UChar32 ch) {

return (ch >= '0' && ch <= '9') || ch == '#' || ch == '*';