appengine/findit/util_scripts/crash_queries/delta_test/run-predator.py - Issue 2605943002: Removing the mutation in the factories for getting dep repositories

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/util_scripts/crash_queries/delta_test/run-predator.py

Issue 2605943002: Removing the mutation in the factories for getting dep repositories (Closed)

Patch Set: Added the Factory method to CachedGitilesRepository Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« appengine/findit/libs/gitiles/gitiles_repository.py ('K') | « appengine/findit/util_scripts/crash_queries/delta_test/run-delta-test.py ('k') | appengine/findit/waterfall/extract_deps_info_pipeline.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/findit/util_scripts/crash_queries/delta_test/run-predator.py

diff --git a/appengine/findit/util_scripts/crash_queries/delta_test/run-predator.py b/appengine/findit/util_scripts/crash_queries/delta_test/run-predator.py

index 882d199edb2d7f8be1c2c47e15a1d72910a21a77..ff30081ea7ef4a248fad6aa17c45c451166a04e5 100644

--- a/appengine/findit/util_scripts/crash_queries/delta_test/run-predator.py

+++ b/appengine/findit/util_scripts/crash_queries/delta_test/run-predator.py

@@ -37,7 +37,7 @@ def StoreResults(crash, client_id, app_id, id_to_culprits, lock, verbose=False):

"""Stores findit result of crash into id_to_culprits dict."""

crash_url = _FRACAS_FEEDBACK_URL_TEMPLATE % (app_id, crash['id'])

try:

- findit = FinditForClientID(client_id, LocalGitRepository())

+ findit = FinditForClientID(client_id, LocalGitRepository)

Sharu Jiang 2016/12/30 00:00:46 I think we should remove ``repo_url`` setter in ``

stacktrace = findit._stacktrace_parser.Parse(

crash['stack_trace'],

ChromeDependencyFetcher(findit._repository).GetDependency(