appengine/findit/util_scripts/crash_queries/delta_test/run-delta-test.py - Issue 2605943002: Removing the mutation in the factories for getting dep repositories

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/util_scripts/crash_queries/delta_test/run-delta-test.py

Issue 2605943002: Removing the mutation in the factories for getting dep repositories (Closed)

Patch Set: Added the Factory method to CachedGitilesRepository Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« appengine/findit/libs/gitiles/gitiles_repository.py ('K') | « appengine/findit/util_scripts/crash_queries/delta_test/delta_util.py ('k') | appengine/findit/util_scripts/crash_queries/delta_test/run-predator.py » ('j') | appengine/findit/util_scripts/crash_queries/delta_test/run-predator.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/findit/util_scripts/crash_queries/delta_test/run-delta-test.py

diff --git a/appengine/findit/util_scripts/crash_queries/delta_test/run-delta-test.py b/appengine/findit/util_scripts/crash_queries/delta_test/run-delta-test.py

index 2d793a544a5c79688ee8c7650ed4f9c8da2c20bd..44ab22b91bd9d32538ad67e9d59de6b29403fd59 100644

--- a/appengine/findit/util_scripts/crash_queries/delta_test/run-delta-test.py

+++ b/appengine/findit/util_scripts/crash_queries/delta_test/run-delta-test.py

@@ -139,6 +139,7 @@ def RunDeltaTest():

delta_result_prefix)

# Check if delta results already existed.

+ # TODO: this code has race conditions for interacting with the file system.

if os.path.exists(delta_csv_path):

print 'Delta results existed in\n%s' % delta_csv_path

if not os.path.exists(delta_path):