Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2985)

Unified Diff: appengine/findit/waterfall/extract_deps_info_pipeline.py

Issue 2605943002: Removing the mutation in the factories for getting dep repositories (Closed)
Patch Set: Added the Factory method to CachedGitilesRepository Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/waterfall/extract_deps_info_pipeline.py
diff --git a/appengine/findit/waterfall/extract_deps_info_pipeline.py b/appengine/findit/waterfall/extract_deps_info_pipeline.py
index 6389265f1044db9ea8dca815b244c3d97732a91c..5c343eac6cd403aaf55ba1bcdfe1544d03522c8f 100644
--- a/appengine/findit/waterfall/extract_deps_info_pipeline.py
+++ b/appengine/findit/waterfall/extract_deps_info_pipeline.py
@@ -7,7 +7,7 @@ import logging
from common import chrome_dependency_fetcher
from common.http_client_appengine import HttpClientAppengine
from common.pipeline_wrapper import BasePipeline
-from gae_libs.gitiles import cached_gitiles_repository
+from gae_libs.gitiles.cached_gitiles_repository import CachedGitilesRepository
def _GetOSPlatformName(master_name, builder_name): # pragma: no cover
@@ -46,8 +46,8 @@ def _GetOSPlatformName(master_name, builder_name): # pragma: no cover
def _GetDependencies(chromium_revision, os_platform):
"""Returns the dependencies used by the specified chromium revision."""
deps = {}
- dep_fetcher=chrome_dependency_fetcher.ChromeDependencyFetcher(
- cached_gitiles_repository.CachedGitilesRepository(HttpClientAppengine()))
+ dep_fetcher = chrome_dependency_fetcher.ChromeDependencyFetcher(
+ CachedGitilesRepository.Factory(HttpClientAppengine()))
for path, dependency in dep_fetcher.GetDependency(
chromium_revision, os_platform).iteritems():
deps[path] = {
@@ -80,8 +80,8 @@ def _DetectDependencyRolls(change_logs, os_platform):
}
"""
deps_rolls = {}
- dep_fetcher=chrome_dependency_fetcher.ChromeDependencyFetcher(
- cached_gitiles_repository.CachedGitilesRepository(HttpClientAppengine()))
+ dep_fetcher = chrome_dependency_fetcher.ChromeDependencyFetcher(
+ CachedGitilesRepository.Factory(HttpClientAppengine()))
for revision, change_log in change_logs.iteritems():
# Check DEPS roll only if the chromium DEPS file is changed by the CL.
for touched_file in change_log['touched_files']:

Powered by Google App Engine
This is Rietveld 408576698