Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: appengine/findit/util_scripts/crash_queries/delta_test/run-predator.py

Issue 2605943002: Removing the mutation in the factories for getting dep repositories (Closed)
Patch Set: Added the Factory method to CachedGitilesRepository Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/util_scripts/crash_queries/delta_test/run-predator.py
diff --git a/appengine/findit/util_scripts/crash_queries/delta_test/run-predator.py b/appengine/findit/util_scripts/crash_queries/delta_test/run-predator.py
index 882d199edb2d7f8be1c2c47e15a1d72910a21a77..ff30081ea7ef4a248fad6aa17c45c451166a04e5 100644
--- a/appengine/findit/util_scripts/crash_queries/delta_test/run-predator.py
+++ b/appengine/findit/util_scripts/crash_queries/delta_test/run-predator.py
@@ -37,7 +37,7 @@ def StoreResults(crash, client_id, app_id, id_to_culprits, lock, verbose=False):
"""Stores findit result of crash into id_to_culprits dict."""
crash_url = _FRACAS_FEEDBACK_URL_TEMPLATE % (app_id, crash['id'])
try:
- findit = FinditForClientID(client_id, LocalGitRepository())
+ findit = FinditForClientID(client_id, LocalGitRepository)
Sharu Jiang 2016/12/30 00:00:46 I think we should remove ``repo_url`` setter in ``
stacktrace = findit._stacktrace_parser.Parse(
crash['stack_trace'],
ChromeDependencyFetcher(findit._repository).GetDependency(

Powered by Google App Engine
This is Rietveld 408576698