appengine/findit/util_scripts/crash_queries/delta_test/delta_util.py - Issue 2605943002: Removing the mutation in the factories for getting dep repositories

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/util_scripts/crash_queries/delta_test/delta_util.py

Issue 2605943002: Removing the mutation in the factories for getting dep repositories (Closed)

Patch Set: Added the Factory method to CachedGitilesRepository Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« appengine/findit/libs/gitiles/gitiles_repository.py ('K') | « appengine/findit/libs/gitiles/test/gitiles_repository_test.py ('k') | appengine/findit/util_scripts/crash_queries/delta_test/run-delta-test.py » ('j') | appengine/findit/util_scripts/crash_queries/delta_test/run-predator.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/findit/util_scripts/crash_queries/delta_test/delta_util.py

diff --git a/appengine/findit/util_scripts/crash_queries/delta_test/delta_util.py b/appengine/findit/util_scripts/crash_queries/delta_test/delta_util.py

index 3aaf3a701675a07e1f3b4a4ba5e7d90e23926945..a5d0e7e12b64c4f863bce26360ecec9cbe04cdef 100644

--- a/appengine/findit/util_scripts/crash_queries/delta_test/delta_util.py

+++ b/appengine/findit/util_scripts/crash_queries/delta_test/delta_util.py

@@ -56,6 +56,8 @@ def ParseGitHash(revision): # pragma: no cover

# TODO(crbug.com/662540): Add unittests.

def EnsureDirExists(path): # pragma: no cover

directory = os.path.dirname(path)

+ # TODO: this has a race condition. Should ``try: os.makedirs`` instead,

+ # discarding the error and returning if the directory already exists.

if os.path.exists(directory):

return