Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1416)

Unified Diff: appengine/findit/libs/gitiles/gitiles_repository.py

Issue 2605943002: Removing the mutation in the factories for getting dep repositories (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/libs/gitiles/gitiles_repository.py
diff --git a/appengine/findit/libs/gitiles/gitiles_repository.py b/appengine/findit/libs/gitiles/gitiles_repository.py
index 599724c3195c934eb3ca78be2afefe04a1bed192..53ad83ed7c2c435ba6a80239696d6b31dfd93808 100644
--- a/appengine/findit/libs/gitiles/gitiles_repository.py
+++ b/appengine/findit/libs/gitiles/gitiles_repository.py
@@ -43,18 +43,10 @@ class GitilesRepository(GitRepository):
def repo_url(self):
return self._repo_url
- @repo_url.setter
- def repo_url(self, repo_url):
- self._repo_url = repo_url
-
@property
def http_client(self):
return self._http_client
- @property
- def identifier(self):
- return self.repo_url
-
def _SendRequestForJsonResponse(self, url, params=None):
if params is None: # pragma: no cover
params = {}

Powered by Google App Engine
This is Rietveld 408576698