Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3037)

Unified Diff: appengine/findit/libs/gitiles/test/gitiles_repository_test.py

Issue 2605943002: Removing the mutation in the factories for getting dep repositories (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/libs/gitiles/test/gitiles_repository_test.py
diff --git a/appengine/findit/libs/gitiles/test/gitiles_repository_test.py b/appengine/findit/libs/gitiles/test/gitiles_repository_test.py
index 8dc1e1298c4543154926039a32d4f0f08fddd068..67680fbb4850673309600bd5adbcb66bc921c518 100644
--- a/appengine/findit/libs/gitiles/test/gitiles_repository_test.py
+++ b/appengine/findit/libs/gitiles/test/gitiles_repository_test.py
@@ -264,13 +264,6 @@ class GitRepositoryTest(TestCase):
self.git_repo = gitiles_repository.GitilesRepository(
self.http_client_for_git, self.repo_url)
- def testGitRepositoryPropertySetters(self):
- git_repo = gitiles_repository.GitilesRepository(self.http_client_for_git)
- git_repo.repo_url = 'https://repo'
- self.assertEqual(git_repo.repo_url, 'https://repo')
- self.assertEqual(git_repo.http_client, self.http_client_for_git)
- self.assertEqual(git_repo.identifier, 'https://repo')
-
def testEndingSlashInRepoUrl(self):
git_repo1 = gitiles_repository.GitilesRepository(
self.http_client_for_git, self.repo_url)

Powered by Google App Engine
This is Rietveld 408576698