Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(816)

Side by Side Diff: appengine/findit/libs/gitiles/gitiles_repository.py

Issue 2605943002: Removing the mutation in the factories for getting dep repositories (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import base64 5 import base64
6 from datetime import datetime 6 from datetime import datetime
7 from datetime import timedelta 7 from datetime import timedelta
8 import json 8 import json
9 import re 9 import re
10 10
(...skipping 25 matching lines...) Expand all
36 self._repo_url = repo_url[:-1] 36 self._repo_url = repo_url[:-1]
37 else: 37 else:
38 self._repo_url = repo_url 38 self._repo_url = repo_url
39 39
40 self._http_client = http_client 40 self._http_client = http_client
41 41
42 @property 42 @property
43 def repo_url(self): 43 def repo_url(self):
44 return self._repo_url 44 return self._repo_url
45 45
46 @repo_url.setter
47 def repo_url(self, repo_url):
48 self._repo_url = repo_url
49
50 @property 46 @property
51 def http_client(self): 47 def http_client(self):
52 return self._http_client 48 return self._http_client
53 49
54 @property
55 def identifier(self):
56 return self.repo_url
57
58 def _SendRequestForJsonResponse(self, url, params=None): 50 def _SendRequestForJsonResponse(self, url, params=None):
59 if params is None: # pragma: no cover 51 if params is None: # pragma: no cover
60 params = {} 52 params = {}
61 params['format'] = 'json' 53 params['format'] = 'json'
62 54
63 # Gerrit prepends )]}' to json-formatted response. 55 # Gerrit prepends )]}' to json-formatted response.
64 prefix = ')]}\'\n' 56 prefix = ')]}\'\n'
65 57
66 status_code, content = self.http_client.Get(url, params) 58 status_code, content = self.http_client.Get(url, params)
67 if status_code != 200: 59 if status_code != 200:
(...skipping 144 matching lines...) Expand 10 before | Expand all | Expand 10 after
212 204
213 for log in data['log']: 205 for log in data['log']:
214 changelogs.append(self._ParseChangeLogFromLogData(log)) 206 changelogs.append(self._ParseChangeLogFromLogData(log))
215 207
216 if 'next' in data: 208 if 'next' in data:
217 next_end_revision = data['next'] 209 next_end_revision = data['next']
218 else: 210 else:
219 next_end_revision = None 211 next_end_revision = None
220 212
221 return changelogs 213 return changelogs
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698