Use consistent types for ICC profiles

third_party/WebKit/Source/platform/graphics/ColorBehavior.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "platform/graphics/ColorBehavior.h"
 
 #include "platform/graphics/BitmapImageMetrics.h"
 #include "wtf/SpinLock.h"
 
 namespace blink {
 
 namespace {
 
 // The output device color space is global and shared across multiple threads.
 SpinLock gTargetColorSpaceLock;
 SkColorSpace* gTargetColorSpace = nullptr;
 
 }  // namespace
 
 // static
-void ColorBehavior::setGlobalTargetColorProfile(
-    const WebVector<char>& profile) {
-  if (profile.isEmpty())
+void ColorBehavior::setGlobalTargetColorSpace(
+    const sk_sp<SkColorSpace>& colorSpace) {
+  if (!colorSpace)
     return;
 
   // Take a lock around initializing and accessing the global device color
   // profile.
   SpinLock::Guard guard(gTargetColorSpaceLock);
 
   // Layout tests expect that only the first call will take effect.
   if (gTargetColorSpace)
     return;
 
-  gTargetColorSpace =
-      SkColorSpace::MakeICC(profile.data(), profile.size()).release();
+  // Ensure that the color space object be leaked.

[jbroman, 2016/12/28 17:08:20]

nit: "is leaked"?

[ccameron, 2016/12/28 21:52:56]

It was intended to be the subjunctive ... but I'm not 100% sure that this is the
right place to use subjunctive.

[jbroman, 2016/12/29 00:09:28]

Indicative sounds better to me, but after searching the web it seems that there
are at least some people who think the subjunctive is fine here. So feel free to
disregard my comment. (I'd assumed a typo -- I don't mean to debate the finer
points of English grammar.)

+  gTargetColorSpace = colorSpace.get();
+  SkSafeRef(gTargetColorSpace);
 
   // UMA statistics.
   BitmapImageMetrics::countOutputGammaAndGamut(gTargetColorSpace);
 }
 
 void ColorBehavior::setGlobalTargetColorSpaceForTesting(
     const sk_sp<SkColorSpace>& colorSpace) {
   // Take a lock around initializing and accessing the global device color
   // profile.
   SpinLock::Guard guard(gTargetColorSpaceLock);
@@ skipping 36 matching lines @@
   if (m_type != Type::TransformTo)
     return true;
   return SkColorSpace::Equals(m_target.get(), other.m_target.get());
 }
 
 bool ColorBehavior::operator!=(const ColorBehavior& other) const {
   return !(*this == other);
 }
 
 }  // namespace blink