Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2605613002:
LocalDOMWindow::reset doesn't need to notify contextDestroyed() (Closed)
DescriptionLocalDOMWindow::reset doesn't need to notify contextDestroyed()
contextDestroyed() should have already been called at Document::shutdown().
This CL adds a DCHECK to verify that contextDestroyed() has been already called
and remove notifyContextDestroyed.
BUG=610176
Committed: https://crrev.com/2c0c11f1d846c6c4207aba6a997dc323f5bb77f5
Cr-Commit-Position: refs/heads/master@{#440731}
Patch Set 1 #Patch Set 2 : temp #Messages
Total messages: 19 (14 generated)
The CQ bit was checked by haraken@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== LocalDOMWindow::reset doesn't need to notify contextDestroyed() BUG= ========== to ========== LocalDOMWindow::reset doesn't need to notify contextDestroyed() contextDestroyed() should have already been called at Document::shutdown(). This CL adds a DCHECK to verify that contextDestroyed() has been already called and remove notifyContextDestroyed. BUG=610176 ==========
haraken@chromium.org changed reviewers: + dcheng@chromium.org
PTAL (PS1 added a CHECK (instead of a DCHECK) and confirmed that all tests pass.)
The CQ bit was checked by haraken@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM
The CQ bit was checked by haraken@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1482812927782740,
"parent_rev": "48ec4b96be8760fdf8d6c8aa5cfd6a07152bbb22", "commit_rev":
"b34849c3c91a821e36c58550222270fa0d33640c"}
Message was sent while issue was closed.
Description was changed from ========== LocalDOMWindow::reset doesn't need to notify contextDestroyed() contextDestroyed() should have already been called at Document::shutdown(). This CL adds a DCHECK to verify that contextDestroyed() has been already called and remove notifyContextDestroyed. BUG=610176 ========== to ========== LocalDOMWindow::reset doesn't need to notify contextDestroyed() contextDestroyed() should have already been called at Document::shutdown(). This CL adds a DCHECK to verify that contextDestroyed() has been already called and remove notifyContextDestroyed. BUG=610176 Review-Url: https://codereview.chromium.org/2605613002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== LocalDOMWindow::reset doesn't need to notify contextDestroyed() contextDestroyed() should have already been called at Document::shutdown(). This CL adds a DCHECK to verify that contextDestroyed() has been already called and remove notifyContextDestroyed. BUG=610176 Review-Url: https://codereview.chromium.org/2605613002 ========== to ========== LocalDOMWindow::reset doesn't need to notify contextDestroyed() contextDestroyed() should have already been called at Document::shutdown(). This CL adds a DCHECK to verify that contextDestroyed() has been already called and remove notifyContextDestroyed. BUG=610176 Committed: https://crrev.com/2c0c11f1d846c6c4207aba6a997dc323f5bb77f5 Cr-Commit-Position: refs/heads/master@{#440731} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/2c0c11f1d846c6c4207aba6a997dc323f5bb77f5 Cr-Commit-Position: refs/heads/master@{#440731} |
