Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

Issue 2605613002: LocalDOMWindow::reset doesn't need to notify contextDestroyed() (Closed)
Patch Set: temp Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
diff --git a/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp b/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
index 1250ed12777b73ff166f44ffc5fe84f57b024122..736aae73a8f3a3c1a809e9315ff5e00dd9f8412c 100644
--- a/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
+++ b/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
@@ -498,9 +498,7 @@ void LocalDOMWindow::registerEventListenerObserver(
void LocalDOMWindow::reset() {
DCHECK(document());
- // Since |Document| class has multiple |LifecycleNotifier| as base class,
- // we need to have |static_cast<ExecutionContext>| here.
- static_cast<ExecutionContext*>(document())->notifyContextDestroyed();
+ DCHECK(document()->isContextDestroyed());
frameDestroyed();
m_screen = nullptr;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698