Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 2605313002: Revert of mac: Don't animate tab close when closing all tabs. (Closed)

Created:
3 years, 11 months ago by erikchen
Modified:
3 years, 11 months ago
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of mac: Don't animate tab close when closing all tabs. (patchset #1 id:1 of https://codereview.chromium.org/2598393003/ ) Reason for revert: Causes crashes: https://bugs.chromium.org/p/chromium/issues/detail?id=677494 Original issue's description: > mac: Don't animate tab close when closing all tabs. > > The animations potentially slow down shutdown, without providing positive > utility. > > BUG=571908 > > Review-Url: https://codereview.chromium.org/2598393003 TBR=asvitkine@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=571908 Committed: https://crrev.com/ad43d1b9352021a7e6d0990b612d3c58c0bd0b37 Cr-Commit-Position: refs/heads/master@{#440972}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
erikchen
Created Revert of mac: Don't animate tab close when closing all tabs.
3 years, 11 months ago (2016-12-29 18:06:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2605313002/1
3 years, 11 months ago (2016-12-29 18:07:06 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2016-12-29 18:24:19 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:52:47 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ad43d1b9352021a7e6d0990b612d3c58c0bd0b37
Cr-Commit-Position: refs/heads/master@{#440972}

Powered by Google App Engine
This is Rietveld 408576698