Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2598393003: mac: Don't animate tab close when closing all tabs. (Closed)

Created:
3 years, 11 months ago by erikchen
Modified:
3 years, 11 months ago
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mac: Don't animate tab close when closing all tabs. The animations potentially slow down shutdown, without providing positive utility. BUG=571908 Committed: https://crrev.com/ca2ba2754ae4ed858ea5ef80632691460b88da5e Cr-Commit-Position: refs/heads/master@{#440806}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
erikchen
asvitkine: Please review.
3 years, 11 months ago (2016-12-27 21:56:23 UTC) #2
Alexei Svitkine (slow)
lgtm
3 years, 11 months ago (2016-12-27 23:27:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2598393003/1
3 years, 11 months ago (2016-12-27 23:38:41 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2016-12-27 23:42:44 UTC) #12
erikchen
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2605313002/ by erikchen@chromium.org. ...
3 years, 11 months ago (2016-12-29 18:06:56 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-02 15:47:51 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ca2ba2754ae4ed858ea5ef80632691460b88da5e
Cr-Commit-Position: refs/heads/master@{#440806}

Powered by Google App Engine
This is Rietveld 408576698