Add WARN_UNUSED_RESULT to base::Time methods that return bool.

components/variations/variations_seed_store.cc

Index: components/variations/variations_seed_store.cc
diff --git a/components/variations/variations_seed_store.cc b/components/variations/variations_seed_store.cc
index 8067651b43545cfdde56d9501a89ec2995f35a05..647cc8dbf9cba17a2d2f09cc77762dccf168874b 100644
--- a/components/variations/variations_seed_store.cc
+++ b/components/variations/variations_seed_store.cc
@@ -139,6 +139,7 @@ enum FirstRunResult {
   FIRST_RUN_SEED_IMPORT_FAIL_NO_CALLBACK,
   FIRST_RUN_SEED_IMPORT_FAIL_NO_FIRST_RUN_SEED,
   FIRST_RUN_SEED_IMPORT_FAIL_STORE_FAILED,
+  FIRST_RUN_SEED_IMPORT_FAIL_INVALID_RESPONSE_DATE,

[Alexei Svitkine (slow), 2017/01/17 21:38:07]

Can you add this to histograms.xml? Seems like you forgot to do this as part of
the change.

[digit1, 2017/01/19 12:57:41]

Thanks for spotting this. Please see the new patch at
https://codereview.chromium.org/2646743003

   FIRST_RUN_RESULT_ENUM_SIZE,
 };
 
@@ -367,7 +368,11 @@ void VariationsSeedStore::ImportFirstRunJavaSeed() {
   }
 
   base::Time current_date;
-  base::Time::FromUTCString(response_date.c_str(), &current_date);
+  if (!base::Time::FromUTCString(response_date.c_str(), &current_date)) {
+    RecordFirstRunResult(FIRST_RUN_SEED_IMPORT_FAIL_INVALID_RESPONSE_DATE);
+    LOG(WARNING) << "Invalid response date: " << response_date;
+    return;
+  }
 
   if (!StoreSeedData(seed_data, seed_signature, seed_country, current_date,
                      false, is_gzip_compressed, nullptr)) {